Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release(v0.53): merge to prod #1641

Merged
merged 17 commits into from
Nov 2, 2023
Merged

release(v0.53): merge to prod #1641

merged 17 commits into from
Nov 2, 2023

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Nov 2, 2023

What's Changed

Full Changelog: v0.54.0...v0.55.0

Post Deploy:

  • Go to growthbook -> homepage_enabled_blocks -> duplicate over changes from staging and make it only for email users; for github users, make sure they see onliy default blocks

dcshzj and others added 11 commits October 26, 2023 18:37
* feat(frontmatter): add rollbackhandler

* fix(edithomepage): use new hook

* refactor(edithomepage): use new hook

* refactor(edithomepage): shift to new hook for features

* fix(featureflags): change derived data

* refactor(herobody): check for enabled change to function

* refactor(featureflag): update namings

* refactor(herobody): use feature key
* fix(media): update preview card API

* chore: add EmptyAlbum image

* styles: adjust design based on latest Figma

* chore(storybook): add more default handlers

* chore: adjust constant location

* feat(media): introduce enhancement to media pages

* chore(storybook): update storybook for media pages

* fix(storybook): remove staging URL handler from defaults

* fix(media): adjust links for image preview card

* test(e2e): update tests to support some of the new flows

* chore(media): remove old ImagePreviewCard component

* fix(contextmenu): remove unneeded z-index

* chore(media): adjust code for easier reading

* fix(media): add router info for ImagePreviewCard storybook

* style(media): adjust stylings based on design feedback

* chore(media): adjust variable names

* chore(media): add comment about use of sx prop

* fix(media): disable checkbox and add back move media functionality temporarily

* chore(media): add comments and use another constant instead
* build(tiptpa): intsall

* build(package): add more deps

* feat(editor): add initial tiptap editor

* feat(context): add context

* build(package): update

* refactor(pagepreview): update components

* refactor(menubar): add file

* feat(editor): update

* feat(iframe): add iframe

* feat(legacyblockview): make draggable

* feat(editor): update

* feat(package): install bubble menu

* feat(linkbubblemenu): add initial modal impl

* refactor(editor): early return in editor to avoid child component checking

* feat(table): add table

* feat(placeholder): add placeholder

* build(types): add types for dompurify

* feat(editor): fixup styling

* feat(editpage): update styling

* fix(site-edit-layout): fix overflow styling

* refactor(page-preview): use back old chunk

* refactor(eidtpage): separate layout/content

* refactor(editor-module): fix styling

* fix(tablebubblemenu): prevent overlap

* refactor(editpage/menu): delete unused stuff, add comments

* refactor(linkbubblemenu): update to open smartly

* fix(menubar): remove extra content

* refactor(editpage): allow mailto protocols and chnage bubble menu behaviour
* refactor(editor): change to new componentns

* fix(fixes): various style fixes

* refactor(editpage): change where context lives

* fix(editpagelayout): persist frontmatter

* refactor(tablemenu): use menuitem

* refactor(markdowneditpage): use infobox

* refactor(iframe): remove extra stuff + rename view

* style(tiptapeditpage): remove extra stuff

* refactor(editor): organise content

* feat(page-settings): update via toggle for variant

* refactor(modal): show editor toggle only if creation

* feat(table): add deletion functionality

* fix(pagesettingscreen): update condition to show toggle

* Revert "refactor(modal): show editor toggle only if creation"

This reverts commit 4eaa29b.
* fix(images): fix image maxW to 50%

* refactor(menubar): change link button impl to open modal

* refactor(editor-modals): update hypertext and file modal behaviour

* fix(editpage): add double quotes

* refactor(types): extract page variant to type
* build(package): update deps

* feat(attachemnt): add initial component (copy from ds)

* feat(icons): add bxerror icon

* feat(attachmenterror): add new component to display errorrs

* feat(attachment): add attachment componnet

* fix(attachmenterror): fix reduce on single item arays

* Update src/components/Attachment/Attachment.tsx

Co-authored-by: Hsu Zhong Jun <[email protected]>

* refactor(styles): change to use bierror; removed unused styles

---------

Co-authored-by: Hsu Zhong Jun <[email protected]>
* feat: update dropdown

* feat: update category dropdown

* feat: update dropdown for workspace
## Problem

Storybooks for the 3 states regarding the site status.
## Problem

Originally wanted to save the person's last save and be more accurate with that specific user, but this would lead to 
1. saving the user's last save time in local storage
2. ^ depending on whether user is using quickie, this will have an impact on the time to actually save in the cms
3. ^ would mean that FE would now be aware if site is quickie whitelisted (not a biggie, but just increases complexity) 

Opting to just use the latest amplify build as a sot instead  

Closes [insert issue #]

## Solution

Note that if a site does not have a record in the db (ie its netlify, this feature will not be shown) 


## Tests

<!-- What tests should be run to confirm functionality? -->

- [ ] Go to a site
- [ ] See that the site status is ready
- [ ] Make a change in a page arbitrary ungrouped page
- [ ] notice that the banner shows pending 
- [ ] do the above two for homepage, + 1 resource page
* feat(media): add delete media modal and story

* feat(media): add multi delete media hook

* fix(media): enhance media workspace for new delete modal

* style(media): decrease line height to center align vertically

* fix(media): add proper ability to delete multiple files without locking

* ref(media): remove unused legacy code

* feat(media): add support for deleting a single media file

* fix(media): reset selected media when type changes

* feat(media): switch to human readable size

* styles(media): add empty directory image

* chore(media): adjust plural sentence

* tests: fix route selector test for EditPage
@seaerchin seaerchin requested a review from a team November 2, 2023 07:59
Copy link

mergify bot commented Nov 2, 2023

⚠️ The sha of the head commit of this PR conflicts with #1640. Mergify cannot evaluate rules on this PR. ⚠️

@dcshzj
Copy link
Contributor

dcshzj commented Nov 2, 2023

#1603 - @dcshzj

  • go to a-test-v4 on staging
  • go to homepage
  • make sure all the blocks are present/can be added
  • go to growthbook and disable some of the flags
  • go back to the cms and reload
  • the unflagged blocks should now be gone
  • check localStorage (dev console -> application)
  • blocks should be there
  • undo the changes to growthbook
  • reload
  • blocks should be present

#1618 - @dcshzj

  • load the editor
  • click on the file/image buttons and make sure they all work

#1625 - @dcshzj
Markdown RTE

  • create a new page using the old RTE
  • type some content in the page (version A)
  • click preview
  • type some content inside the editor (version A')
  • click close (ie, reject update)
  • content should not change (still show version A in old RTE)
  • type some extra content in old RTE (version B)
  • click preview
  • the content inside the new RTE should show version B.
  • type some content in new RTE (B')
  • click I'm in
  • new RTE shuold display with content B'

Tiptap RTE

  • create a new page using the new RTE
  • click into page
  • should show new RTE
  • make some changes
  • click save
  • exit the page
  • click back in
  • changes shuold still be there
  • should still use new RTE
  • exit the page
  • toggle to old RTE
  • go back in
  • should display content as html

#1624 - no tests

#1638/#1633 - no tests

@dcshzj
Copy link
Contributor

dcshzj commented Nov 2, 2023

#1628 - @seaerchin

  • Navigate to any site
  • Perform CRUD operations of the media interface and make sure that they still work as intended

#1630 - @seaerchin

  • Ensure clicking on dropdown on image album reflects above UI and you can perform the actions on the dropdown
  • Ensure clicking on dropdown on folders reflects above UI and you can perform the actions on the dropdown
  • Ensure clicking on dropdown on resource category reflects above UI and you can perform the actions on the dropdown
  • Ensure clicking on dropdown on workspace folders reflects above UI and you can perform the actions on the dropdown

#1635 - no tests

#1636 - @seaerchin

  • Go to a site
  • See that the site status is ready
  • Make a change in a page arbitrary ungrouped page
  • notice that the banner shows pending
  • do the above two for homepage, + 1 resource page

#1634 - @seaerchin

  • Go to any site and enter the media workspace
  • Select 1 image, go to the "Edit selected" menu and select "Delete all"
  • Verify that the delete modal appears and the image can be deleted
  • Select multiple images, go to the "Edit selected" menu and select "Delete all"
  • Verify that the delete modal appears and the images can be deleted
  • Go to an individual image and click on the kebob menu, then click "Delete image"
  • Verify that the delete modal appears and the image can be deleted
  • Enter the file workspace
  • Go to an individual image and click on the kebob menu, then click "Delete file"
  • Verify that the delete modal appears and the file can be deleted

@seaerchin seaerchin temporarily deployed to staging November 2, 2023 08:11 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging November 2, 2023 08:13 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging November 2, 2023 08:14 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging November 2, 2023 08:15 — with GitHub Actions Inactive
Copy link

cypress bot commented Nov 2, 2023

47 failed tests on run #425 ↗︎

47 59 1 24 Flakiness 0

Details:

release(v0.53): merge to prod
Project: isomercms-frontend Commit: 060c193e97
Status: Failed Duration: 25:52 💡
Started: Nov 2, 2023 11:14 AM Ended: Nov 2, 2023 11:40 AM
Failed  editPage.spec.ts • 8 failed tests

View Output Video

Test Artifacts
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to modify and save content Output Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add existing image Output Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow user to add link Output Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should allow users to add Instagram embed script Output Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add untrusted external scripts Output Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add inline scripts Output Screenshots Video
editPage.spec > Edit collection page > Edit page (collection) should have correct colour Output Screenshots Video
editPage.spec > Edit resource page > Edit page (resource) should have correct colour Output Screenshots Video
Failed  files.spec.ts • 8 failed tests

View Output Video

Test Artifacts
Files > Create file, delete file, edit file settings in Files > Files should contain Directories and Ungrouped Files Output Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to edit a file Output Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should not be able to create file with invalid title Output Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should not be able to edit file and save with invalid title Output Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to delete file Output Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to edit file directory name Output Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to delete file directory Output Screenshots Video
Files > Create file, delete file, edit file settings, and move files in file directories > Should be able to add file to file directory Output Screenshots Video
Failed  folders.spec.ts • 12 failed tests

View Output Video

Test Artifacts
Folders flow > Create page, delete page, edit page settings in folder > Should be able to create a new page with valid title and permalink Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should not be able to create page with invalid title Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should not be able to create page with invalid permalink Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to edit existing page details with Chinese title and valid permalink Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to edit existing page details with Tamil title and valid permalink Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to delete existing page in folder Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in subfolder > Should be able to create a new page with valid title and permalink Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in subfolder > Should not be able to create page with invalid title Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in subfolder > Should not be able to create page with invalid permalink Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in subfolder > Should be able to edit existing page details with Chinese title and valid permalink Output Screenshots Video
The first 10 failed tests are shown, see all 12 tests in Cypress Cloud.
Failed  homepage.spec.ts • 6 failed tests

View Output Video

Test Artifacts
Homepage > Block editing > should display the site notification correctly Output Screenshots Video
Homepage > Block editing > should only allow up to 4 highlights for the hero section Output Screenshots Video
Homepage > Block editing > should remove the button in preview when the hero button content is not given Output Screenshots Video
Homepage > Block editing > should preserve content when swapping between highlights and dropdown for hero section Output Screenshots Video
Homepage > Block editing > should limit users to a single resource component Output Screenshots Video
Homepage > Block editing > should rearrange the blocks correctly and the preview should also reflect the new order Output Screenshots Video
Failed  images.spec.ts • 3 failed tests

View Output Video

Test Artifacts
Images > Create album, delete album, edit album settings in Images > Should be able to edit album name Output Screenshots Video
Images > Create album, delete album, edit album settings in Images > Should be able to delete album Output Screenshots Video
Images > Create image, delete image, edit image settings, and move images in image albums > Should be able to add image to image album Output Screenshots Video

The first 5 failed specs are shown, see all 10 specs in Cypress Cloud.

Review all test suite changes for PR #1641 ↗︎

@seaerchin seaerchin temporarily deployed to staging November 2, 2023 09:14 — with GitHub Actions Inactive
* feat(ff): add feature flag for editpage

* refactor(editpage): fix styling + add modals

* feat(editpage): shift modals over to layout

* feat(editpage): override content on successful save
Copy link

mergify bot commented Nov 2, 2023

⚠️ The sha of the head commit of this PR conflicts with #1640. Mergify cannot evaluate rules on this PR. ⚠️

@mergify mergify bot mentioned this pull request Nov 2, 2023
@seaerchin seaerchin temporarily deployed to staging November 2, 2023 10:41 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging November 2, 2023 10:43 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging November 2, 2023 10:53 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging November 2, 2023 11:09 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging November 2, 2023 11:12 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging November 2, 2023 11:22 — with GitHub Actions Inactive
Copy link

mergify bot commented Nov 2, 2023

⚠️ The sha of the head commit of this PR conflicts with #1640. Mergify cannot evaluate rules on this PR. ⚠️

@seaerchin seaerchin temporarily deployed to staging November 2, 2023 12:18 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging November 2, 2023 12:18 — with GitHub Actions Inactive
@seaerchin seaerchin merged commit 7133e2c into master Nov 2, 2023
16 checks passed
@seaerchin seaerchin deleted the release/v0.53.0 branch November 2, 2023 12:19
@kishore03109 kishore03109 restored the release/v0.53.0 branch November 3, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants