release(0.41.0): merge to `prod` #1464

seaerchin · 2023-08-30T09:05:28Z

Env vars

~~REACT_APP_GROWTHBOOK_CLIENT_KEY : this is required for GrowthBook SDK to connect with the cloud~~

Co-authored-by: seaerchin <[email protected]>

Release / 0.40.0

* Add submarine image for NotFoundPage * Add new version of the NotFoundPage * Add storybook stories for new NotFoundPage * Fix unit test for RouteSelector * fix(ui): changes based on design feedback

* feat: add growthbook as dep * feat: add growthbook to app * feat: inject user attributes * feat: add default dev mode to be false * feat: inject site name as attribute * feat: add types and featur flag list * chore: minor fixes * feat: add type and conditional siteName attribute * fix: enable dev mode only for local dev * chore: remove duplicate comment

* feat: update text assertion * fix: resources text assertion * fix: method to remove other collaborators * fix: uncomment code * feat: extract constant * feat: swap removeFirstCollaborator with removeOtherCollaborators * fix: use removeOtherCollaborators * chore: remove unused import and function

* refactor(edithomepage): use new constants * refactor(edithomepage): shift to new folder * refactor(edithomepage): shift preview out into own section --------- Co-authored-by: seaerchin <[email protected]>

* feat: introduce interface, remove constants file * fix: comment out sample flags

* Enhance AddSectionButton to allow adjusting button text * Add various sections of contact us page * Adjust Editable to allow new droppable zones * Update validators to match Figma messages * Introduce feature-flagged contact us page * Remove unneeded comment * Switch to use editable contexts instead and use modal * Fix validation condition * Fix name for FeatureFlaggedContactUs * Remove some unnecessary casts * Fix RouteSelector unit test

* chore: update editable types to allow nav * feat: add pageMenuBody * feat: add resourceMenuBody * feat: add folderMenuBody * feat: add GroupMenuBody * feat: swap new components into editNavBar * chore: fix text for components * Fix: addSectionButton button text prop * chore: pass props to button instead of box * chore: add feature flag for new nav bar (#1459) * chore: add feature flag for new nav bar * fix: tests

* feat(feature-flag): add feature flag from gb * refactor(navbar): use gb for ff * refactor(feature-flag): add types --------- Co-authored-by: seaerchin <[email protected]>

Co-authored-by: seaerchin <[email protected]>

* refactor(edithomepage): smooth scroll * fix: only scroll after first load * chore: fix rebase errors * Revert "fix: only scroll after first load" This reverts commit 158a4df. * Revert "refactor(edithomepage): smooth scroll" This reverts commit e555c2f. * fix: firstLoad condition * chore: move first load check to separate method * fix: smooth scroll --------- Co-authored-by: seaerchin <[email protected]> Co-authored-by: Alexander Lee <[email protected]>

* chore: add util method to retrieve image path * fix: replace image retrieval in homepage template components with updated v2 endpoint * fix: change return of util method to handle nested * Update src/utils/images.ts Co-authored-by: Qilu Xie <[email protected]> * Update src/utils/images.ts Co-authored-by: Qilu Xie <[email protected]> * chore: fix styling * refactor: move image fetching to separate hook --------- Co-authored-by: Qilu Xie <[email protected]>

mergify · 2023-08-30T09:06:02Z

⚠️ The sha of the head commit of this PR conflicts with #1463. Mergify cannot evaluate rules on this PR. ⚠️

seaerchin · 2023-08-30T09:19:05Z

#1435 @seaerchin

Navigate to a random non-existent page outside of a site (i.e. /not/found), the "Back to dashboard" button should link you to /sites.
Navigate to a random non-existent page within a site (i.e. /sites/zhongjun-test/notfound), the "Back to dashboard button should link you to /sites/zhongjun-test.

seaerchin · 2023-08-30T09:19:42Z

seaerchin · 2023-08-30T09:20:42Z

#1458 @harishv7

Navigate to Contact Us page for a site that has this new stylings enabled (defined in OGP_SITES and TESTING_SITES)
Add new location section and contact information section. This should work as intended.
Edit the fields in existing and new sections, the preview should update and validation feedback should appear immediately.
Delete a card in the location section and contact information section.
Add cards in the operating hours section of any location.
Edit the fields in the operating hours card.
Delete an operating hours card.
Drag and drop for first level (locations and contact information), and for second level (operating hours in location) should work as intended.
Save changes to the contact us page. The staging site should build in a way that is similar to how the preview looks.

seaerchin · 2023-08-30T09:21:24Z

seaerchin · 2023-08-30T09:21:57Z

#1462 combined with gb ff tests in #1449

seaerchin · 2023-08-30T09:22:21Z

#1450 @harishv7

open hero section
notification should not have optional tag after the form's label
add infobar
infobar should not have optional tag after the form's label

seaerchin · 2023-08-30T09:22:58Z

#1439 @seaerchin

Navigate to homepage
- Preview should remain at hero and not scroll down
- When expanding a section it should smooth scroll to the section
- When adding a new section it should smooth scroll to the bottom

@alexanderleegs pls help add thx

seaerchin · 2023-08-30T09:23:22Z

#1461 @seaerchin

Go to edithomepage for any private repo (e.g. a-test-v4)
Verify that images show up on
- Hero banner
- Left infopic
- Right infopic
Verify that nested images work as well (e.g. /images/album/nested.jpg)
When creating a new infopic section, no error toast should appear

cypress · 2023-08-30T09:23:36Z

39 failed tests on run #325 ↗︎

39	130	2	8	0

Details:

release(0.41.0): merge to
Project: isomercms-frontend	Commit: `3ce055b04f`
Status: Failed	Duration: 36:06 💡
Started: Aug 30, 2023 11:00 AM	Ended: Aug 30, 2023 11:36 AM

collaborators.spec.ts • 3 failed tests

View Output Video

Test		Artifacts
collaborators flow > Admin adding a collaborator > should be able to add a collaborator		`Output` `Screenshots` `Video`
collaborators flow > Admin removing a collaborator > should be able to remove an existing collaborator		`Output` `Screenshots` `Video`
collaborators flow > Admin removing a collaborator > should not be able to remove the last site member		`Output` `Screenshots` `Video`

comments.spec.ts • 6 failed tests

View Output Video

Test		Artifacts
Comments > common > should be able to see comments posted by others		`Output` `Screenshots` `Video`
Comments > common > should be able to see comments posted by yourself		`Output` `Screenshots` `Video`
Comments > common > should not allow empty comments to be posted		`Output` `Screenshots` `Video`
Comments > admin and collaborator of site > should be able to post comments if you are an admin of the site		`Output` `Screenshots` `Video`
Comments > admin and collaborator of site > should be able to post comments if you are a collaborator of the site		`Output` `Screenshots` `Video`
Comments > no access rights > should not be able to create comments for a site which one is not a site member		`Output` `Screenshots` `Video`

editPage.spec.ts • 3 failed tests

View Output Video

Test		Artifacts
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add untrusted external scripts		`Output` `Screenshots` `Video`
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add inline scripts		`Output` `Screenshots` `Video`
editPage.spec > Edit resource page > Edit page (resource) should have correct colour		`Output` `Screenshots` `Video`

folders.spec.ts • 1 failed test

View Output Video

Test		Artifacts
Folders flow > Create page, delete page, edit page settings in folder > Should be able to edit existing page details with Tamil title and valid permalink		`Output` `Screenshots` `Video`

homepage.spec.ts • 6 failed tests

View Output Video

Test		Artifacts
Homepage > Block editing > should display the site notification correctly		`Output` `Screenshots` `Video`
Homepage > Block editing > should only allow up to 4 highlights for the hero section		`Output` `Screenshots` `Video`
Homepage > Block editing > should remove the button in preview when the hero button content is not given		`Output` `Screenshots` `Video`
Homepage > Block editing > should preserve content when swapping between highlights and dropdown for hero section		`Output` `Screenshots` `Video`
Homepage > Block editing > should limit users to a single resource component		`Output` `Screenshots` `Video`
Homepage > Block editing > should rearrange the blocks correctly and the preview should also reflect the new order		`Output` `Screenshots` `Video`

The first 5 failed specs are shown, see all 10 specs in Cypress Cloud.

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

seaerchin and others added 16 commits August 24, 2023 10:25

docs(editable): add docs for drag drop stuf (#1445)

e2e9eb7

Co-authored-by: seaerchin <[email protected]>

fix(editable): shift out contxt to allow nested dnd (#1448)

19b6a36

Co-authored-by: seaerchin <[email protected]>

Merge pull request #1446 from isomerpages/release/0.40.0

b445913

Release / 0.40.0

feat: introduce new version of NotFoundPage (#1435)

2cb6ae8

* Add submarine image for NotFoundPage * Add new version of the NotFoundPage * Add storybook stories for new NotFoundPage * Fix unit test for RouteSelector * fix(ui): changes based on design feedback

chore(edithomepage): shift constants out (#1416)

d73f325

* refactor(edithomepage): use new constants * refactor(edithomepage): shift to new folder * refactor(edithomepage): shift preview out into own section --------- Co-authored-by: seaerchin <[email protected]>

IS-508: Introduce Interface for GrowthBook (#1455)

8c2f345

* feat: introduce interface, remove constants file * fix: comment out sample flags

chore: set pointerEvents to none for draggable icon button (#1456)

5c13c2c

feat(feature-flag): add feature flag from gb (#1462)

f0a96e0

* feat(feature-flag): add feature flag from gb * refactor(navbar): use gb for ff * refactor(feature-flag): add types --------- Co-authored-by: seaerchin <[email protected]>

fix(edithomepage): remove optional tags (#1450)

ae67b0f

Co-authored-by: seaerchin <[email protected]>

0.41.0

3ce055b

seaerchin requested a review from a team August 30, 2023 09:11

seaerchin temporarily deployed to staging August 30, 2023 09:15 — with GitHub Actions Inactive

seaerchin had a problem deploying to staging August 30, 2023 09:17 — with GitHub Actions Failure

seaerchin temporarily deployed to staging August 30, 2023 09:17 — with GitHub Actions Inactive

seaerchin temporarily deployed to staging August 30, 2023 09:18 — with GitHub Actions Inactive

seaerchin had a problem deploying to staging August 30, 2023 09:26 — with GitHub Actions Failure

seaerchin had a problem deploying to staging August 30, 2023 10:17 — with GitHub Actions Failure

seaerchin had a problem deploying to staging August 30, 2023 10:57 — with GitHub Actions Failure

seaerchin temporarily deployed to staging August 31, 2023 05:21 — with GitHub Actions Inactive

seaerchin temporarily deployed to staging August 31, 2023 05:33 — with GitHub Actions Inactive

harishv7 approved these changes Aug 31, 2023

View reviewed changes

seaerchin merged commit 7dc0fed into master Aug 31, 2023

mergify bot deleted the release/v0.41.0 branch August 31, 2023 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release(0.41.0): merge to `prod` #1464

release(0.41.0): merge to `prod` #1464

seaerchin commented Aug 30, 2023 •

edited

Loading

mergify bot commented Aug 30, 2023

seaerchin commented Aug 30, 2023 •

edited

Loading

seaerchin commented Aug 30, 2023 •

edited

Loading

seaerchin commented Aug 30, 2023 •

edited by harishv7

Loading

seaerchin commented Aug 30, 2023 •

edited

Loading

seaerchin commented Aug 30, 2023

seaerchin commented Aug 30, 2023 •

edited by harishv7

Loading

seaerchin commented Aug 30, 2023 •

edited

Loading

seaerchin commented Aug 30, 2023 •

edited

Loading

cypress bot commented Aug 30, 2023 •

edited

Loading

release(0.41.0): merge to prod #1464

release(0.41.0): merge to prod #1464

Conversation

seaerchin commented Aug 30, 2023 • edited Loading

Env vars

mergify bot commented Aug 30, 2023

seaerchin commented Aug 30, 2023 • edited Loading

seaerchin commented Aug 30, 2023 • edited Loading

seaerchin commented Aug 30, 2023 • edited by harishv7 Loading

seaerchin commented Aug 30, 2023 • edited Loading

seaerchin commented Aug 30, 2023

seaerchin commented Aug 30, 2023 • edited by harishv7 Loading

seaerchin commented Aug 30, 2023 • edited Loading

seaerchin commented Aug 30, 2023 • edited Loading

cypress bot commented Aug 30, 2023 • edited Loading

39 failed tests on run #325 ↗︎

release(0.41.0): merge to `prod` #1464

release(0.41.0): merge to `prod` #1464

seaerchin commented Aug 30, 2023 •

edited

Loading

seaerchin commented Aug 30, 2023 •

edited

Loading

seaerchin commented Aug 30, 2023 •

edited

Loading

seaerchin commented Aug 30, 2023 •

edited by harishv7

Loading

seaerchin commented Aug 30, 2023 •

edited

Loading

seaerchin commented Aug 30, 2023 •

edited by harishv7

Loading

seaerchin commented Aug 30, 2023 •

edited

Loading

seaerchin commented Aug 30, 2023 •

edited

Loading

cypress bot commented Aug 30, 2023 •

edited

Loading