-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(siteLaunchPad): Disclaimer pages Storybook #1308
Conversation
3515832
to
553a039
Compare
4bb65a1
to
7311b3d
Compare
@kishore03109 the arrow change should also be the icon, from |
@NatMaeTan ye video outdated, rest assured the arrow changed already |
f77ff5b
to
95ce29f
Compare
@@ -90,6 +91,12 @@ export const RouteSelector = () => ( | |||
</SiteLaunchProvider> | |||
</ProtectedRouteWithProps> | |||
|
|||
<ProtectedRouteWithProps path="/sites/:siteName/siteLaunchPad"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be behind a feature flag since we will only launch this later? For now can manually have a featureFlag.ts which exports allowSiteLaunch=false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey it feels weird to have biz logic there, and there is already a util file shouldUseSiteLaunchFeature
. Would you be ok with <SiteLaunchPad>
taking care of this responsibility, and showing a text like Site Launch Feature is not enabled for this site
? Since this will involve creating a another story + asking Nat for UI, I am tempted to tackle it in a separate PR. If ok, Ill go ahead to raise a issue for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/layouts/SiteLaunchPad/components/SiteLaunchInfoGathering.tsx
Outdated
Show resolved
Hide resolved
info gathering pages
change func name for clarity
src/layouts/SiteLaunchPad/components/SiteLaunchInfoGathering.tsx
Outdated
Show resolved
Hide resolved
fd4a79a
to
5aa4647
Compare
@NatMaeTan background changed liao, can proceed to review |
!run-chromatic |
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
Problem
Figma for site launch pad, without the checklist pages
Solution
Similar to #1296, this PR builds a storybook component on the site launch pad page.
This is meant to be more of a UI focused PR only, the functionality + integration with backend will be introduced in a separate PR instead. Considered to be safe to merge to master since it be hidden behind a feature flag.
Storybook
Screen.Recording.2023-06-15.at.10.33.48.AM.mov
NOTE: The pages will loop back because the checklist page is not tackled in this PR (done in #1297)
Tests
New Storybook page for SiteLaunchPad
To view the site launch pad directly
http://localhost:3000/sites/<siteName>/siteLaunchPad
To view the entire flow within storybook:
npm run storybook
Design Review Notes
As discussed, arrow changed: