Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(siteLaunchPad): Disclaimer pages Storybook #1308

Merged
merged 23 commits into from
Jun 28, 2023

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Jun 15, 2023

Problem

Figma for site launch pad, without the checklist pages

Solution

Similar to #1296, this PR builds a storybook component on the site launch pad page.

This is meant to be more of a UI focused PR only, the functionality + integration with backend will be introduced in a separate PR instead. Considered to be safe to merge to master since it be hidden behind a feature flag.

Storybook

Screen.Recording.2023-06-15.at.10.33.48.AM.mov

NOTE: The pages will loop back because the checklist page is not tackled in this PR (done in #1297)

Tests

New Storybook page for SiteLaunchPad
To view the site launch pad directly

  1. add your site name to the env var
  2. go to http://localhost:3000/sites/<siteName>/siteLaunchPad
  3. click through the UI

To view the entire flow within storybook:

  1. npm run storybook
  2. after building the storybook, click here

Design Review Notes

As discussed, arrow changed:
Screenshot 2023-06-19 at 9 09 06 AM
Screenshot 2023-06-19 at 9 10 02 AM

@kishore03109 kishore03109 marked this pull request as ready for review June 15, 2023 02:24
@kishore03109 kishore03109 changed the title Feat/siteLaunchPadDisclamerStorybook Feat(siteLaunchPad): Disclaimer pages Storybook Jun 15, 2023
@kishore03109 kishore03109 temporarily deployed to staging June 15, 2023 02:34 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 15, 2023 02:35 — with GitHub Actions Inactive
@kishore03109 kishore03109 force-pushed the feat/sitedashBoardStories branch from 3515832 to 553a039 Compare June 16, 2023 11:51
@kishore03109 kishore03109 force-pushed the feat/siteLaunchPadDisclamerStorybook branch from 4bb65a1 to 7311b3d Compare June 19, 2023 00:55
@kishore03109 kishore03109 temporarily deployed to staging June 19, 2023 01:05 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 19, 2023 01:21 — with GitHub Actions Inactive
@NatMaeTan
Copy link
Contributor

@kishore03109 the arrow change should also be the icon, from chevron-right to right-arrow-alt. The screenshots didn't show it but the video is using the chevrons so not sure if it's been fixed!

@kishore03109 kishore03109 requested a review from NatMaeTan June 19, 2023 05:38
@kishore03109
Copy link
Contributor Author

@NatMaeTan ye video outdated, rest assured the arrow changed already

@kishore03109 kishore03109 changed the base branch from feat/sitedashBoardStories to develop June 19, 2023 07:08
@kishore03109 kishore03109 force-pushed the feat/siteLaunchPadDisclamerStorybook branch from f77ff5b to 95ce29f Compare June 19, 2023 07:18
@kishore03109 kishore03109 temporarily deployed to staging June 19, 2023 07:18 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 19, 2023 07:32 — with GitHub Actions Inactive
src/layouts/SiteLaunchPad/SiteLaunchPad.tsx Outdated Show resolved Hide resolved
src/layouts/SiteLaunchPad/SiteLaunchPad.tsx Show resolved Hide resolved
src/layouts/SiteLaunchPad/SiteLaunchPad.tsx Outdated Show resolved Hide resolved
src/layouts/SiteLaunchPad/SiteLaunchPad.tsx Outdated Show resolved Hide resolved
src/layouts/SiteLaunchPad/SiteLaunchPad.tsx Outdated Show resolved Hide resolved
src/layouts/SiteDashboard/SiteDashboard.tsx Show resolved Hide resolved
@kishore03109 kishore03109 temporarily deployed to staging June 21, 2023 14:45 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 21, 2023 14:59 — with GitHub Actions Inactive
@@ -90,6 +91,12 @@ export const RouteSelector = () => (
</SiteLaunchProvider>
</ProtectedRouteWithProps>

<ProtectedRouteWithProps path="/sites/:siteName/siteLaunchPad">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be behind a feature flag since we will only launch this later? For now can manually have a featureFlag.ts which exports allowSiteLaunch=false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey it feels weird to have biz logic there, and there is already a util file shouldUseSiteLaunchFeature. Would you be ok with <SiteLaunchPad> taking care of this responsibility, and showing a text like Site Launch Feature is not enabled for this site? Since this will involve creating a another story + asking Nat for UI, I am tempted to tackle it in a separate PR. If ok, Ill go ahead to raise a issue for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1324
@harishv7 fixed here

@kishore03109 kishore03109 temporarily deployed to staging June 22, 2023 00:42 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 22, 2023 00:57 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 22, 2023 01:12 — with GitHub Actions Inactive
@kishore03109 kishore03109 force-pushed the feat/siteLaunchPadDisclamerStorybook branch from fd4a79a to 5aa4647 Compare June 22, 2023 08:51
@kishore03109 kishore03109 temporarily deployed to staging June 22, 2023 09:03 — with GitHub Actions Inactive
@kishore03109 kishore03109 requested a review from harishv7 June 23, 2023 01:39
@kishore03109
Copy link
Contributor Author

@NatMaeTan background changed liao, can proceed to review

@kishore03109 kishore03109 temporarily deployed to staging June 23, 2023 01:53 — with GitHub Actions Inactive
@kishore03109
Copy link
Contributor Author

!run-chromatic

@kishore03109 kishore03109 merged commit 51e4009 into develop Jun 28, 2023
@kishore03109 kishore03109 deleted the feat/siteLaunchPadDisclamerStorybook branch June 28, 2023 06:11
@mergify mergify bot requested a review from a team July 28, 2023 06:12
@mergify
Copy link

mergify bot commented Jul 28, 2023

This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants