fix(permalinks): default permalink for create #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @kishore03109 and the rest of your teammates on |
kishore03109
force-pushed
the
03-14-fix_permalinks_default_permalink_for_create
branch
2 times, most recently
from
d036802 to
c96bc10
Compare
kishore03109
force-pushed
the
03-14-fix_permalinks_default_permalink_for_create
branch
from
c96bc10 to
3f3f0ae
Compare
seaerchin
approved these changes
Mar 19, 2024
2 tasks
kishore03109
deleted the
03-14-fix_permalinks_default_permalink_for_create
branch
kishore03109
added a commit
that referenced
this pull request
Mar 21, 2024
## Problem same as #1843 but for resource pages ## Tests follow video https://github.com/isomerpages/isomercms-frontend/assets/42832651/f545f927-90ba-4daf-a555-62f5b1a834f7 - [ ] create a resource page, note that you should be unable to modify the permalink - [ ] edit resource page modal's functionality remains the same, we dont still allow them to change to whatever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have quite a number of duplicate permalinks
this does not fix the problem completely, but it does allow for some sort of preventive measure to prevents accidental dups.
we are not sure if of the number of agencies that use dup permalinks for the sake of playground, and it would be hard to enforce this until we have the functionality for playground out. more context here
Solution
sane default when creating a page.
Breaking Changes
Tests
follow video
Screen.Recording.2024-03-14.at.3.15.06.PM.mov