IS-678: UI changes for album tile #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Haven't update E2E (if needed) |
seaerchin
approved these changes
Oct 31, 2023
Comment on lines
-48
to
-53
| icon={<BiEditAlt />} | ||
| as={RouterLink} | ||
| to={`/sites/${siteName}/media/${mediaType}/mediaDirectory/${encodedDirectoryPath}`} | ||
| > | ||
| <Text>Edit folder</Text> | ||
| </ContextMenu.Item> |
There was a problem hiding this comment.
not sure if this is covered later on but how are we allowing them to edit the folder in this case?
There was a problem hiding this comment.
Wait current understanding is Edit folder just allows user to rename folder, pls correct me if otherwise
There was a problem hiding this comment.
- "Edit ____" for folder / album / category / page: used to be the same as "open"
- "Edit ____" for file / image: used to be the same as "rename" (= also called "Settings" on the modal)
Imo #1 is okay to get rid of becos it's the same as just clicking on the tile
#2 is covered by the new "Rename" option
|
@harishv7 Screenshots look good! |
This was referenced Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Implement UI changes for album tile. Currently, our "edit" in the dropdown is just equivalent to clicking the tile and "settings" just does rename of the folder.
Closes IS-678
Solution
Took the liberty to update across images + files, resource room and workspace.
UI should look like this. For full design see Figma link on ticket IS-678
Breaking Changes
Before & After Screenshots
BEFORE:
AFTER:
Tests
npm run tests)!run e2e)