feat(isobot): add locking/cloning functionalities #1392
Conversation
seaerchin
changed the title
add whitelisting
add endpoints for cloning and locking
change to class
shift to using the class
seaerchin
force-pushed
the
feat/isobot-repair
branch
from
193da34 to
ec780f9
Compare
seaerchin
requested review from
harishv7,
alexanderleegs,
dcshzj and
kishore03109
| @@ -16,11 +23,37 @@ const token = config.get("slackbot.token") | |||
| const botReceiver = new ExpressReceiver({ signingSecret, endpoints: "/" }) | |||
| export const isobotRouter = botReceiver.router | |||
|
|
|||
| // TODO: add slack ids of isomer user | |||
| const ISOMER_USERS_ID = ["U01HTSFC0RY"] | |||
There was a problem hiding this comment.
should we be hardcoding this? Or fetch it dynamically? Else every member movement in team will require a change
An alternative I can think of is to fetch members of the isomer-team and then check if the user is within this team. I believe the team will be more permanent than a user id
There was a problem hiding this comment.
ok this sounds good to me, i'll make this change!
| await ack() | ||
|
|
||
| const HELP_TEXT = | ||
| "Usage: `/clone <github_repo_name>`. Take note that this locks the repo for 15 minutes by default. To bypass this behaviour, add `-n` at the end of the command" |
There was a problem hiding this comment.
us clone the right term? we usually refer to it as a repair?
There was a problem hiding this comment.
the repair does a lock -> clone -> unlock under the hood!
There was a problem hiding this comment.
correct, hence the 3-step process is called repair
| await ack() | ||
|
|
||
| const HELP_TEXT = | ||
| "Usage: `/lock <github_repo_name> -d <duration_in_minutes>`. Take note that this locks the repo for 15 minutes by default if `-d` is not specified" |
There was a problem hiding this comment.
should d also have a max time? what if someone puts in an accidental 10000000 mins or something?
There was a problem hiding this comment.
makes sense, will make this change
Problem
We want to shift locking/unlocking functionality into a slack bot because using the form is unwieldy. This is because we have to log into form sg -> otp -> find form -> otp again.
Solution
error.causeinunlockformutex-utils. as is, the current return fromunlockis pretty useless