-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inheritance-report): text adjustments #16649
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1349,8 +1349,9 @@ export const m = defineMessages({ | |
description: '', | ||
}, | ||
heirsDescriptionPrePaid: { | ||
id: 'ir.application:heirsDescriptionPrePaid', | ||
defaultMessage: 'Lorem ipsum lorem ipsum', | ||
id: 'ir.application:heirsDescriptionPrePaid#markdown', | ||
defaultMessage: | ||
'Vinsamlegast skráðu upplýsingar um þá erfingja sem eiga að taka við fyrirframgreiddum arfi.', | ||
description: '', | ||
}, | ||
heirsAndPartition: { | ||
|
@@ -1474,6 +1475,11 @@ export const m = defineMessages({ | |
defaultMessage: 'Forsjáraðili/málsvari/sérstakur lögráðamaður', | ||
description: 'Custody label', | ||
}, | ||
inheritanceAdvocateLabelPrePaid: { | ||
id: 'ir.application:inheritanceAdvocateLabelPrePaid', | ||
defaultMessage: 'Forsjáraðili/málsvari/sérstakur lögráðamaður', | ||
description: 'Custody label', | ||
}, | ||
Comment on lines
+1478
to
+1482
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Consider consolidating duplicate messages. The message - inheritanceAdvocateLabelPrePaid: {
- id: 'ir.application:inheritanceAdvocateLabelPrePaid',
- defaultMessage: 'Forsjáraðili/málsvari/sérstakur lögráðamaður',
- description: 'Custody label',
- }, Then update the component to use
|
||
errorSpouseCount: { | ||
id: 'ir.application:errorSpouseCount', | ||
defaultMessage: 'Aðeins er hægt að hafa einn erfingja sem maka', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Refactor duplicate advocate label logic.
The same conditional rendering logic is duplicated from the first advocate section. Consider extracting this into a reusable component or constant to follow DRY principles.
Example implementation: