Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement that gpg is not a symlink #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove requirement that gpg is not a symlink #259

wants to merge 1 commit into from

Conversation

007
Copy link

@007 007 commented May 16, 2019

Requiring this check breaks compatibility with real-life. If I have a symlink to gpg in my path this will ignore that and report GnuPG is not installed! even though I can execute gpg myself and it works fine.

This also explicitly breaks compatibility with OSX homebrew, which uses symlinks to manage versioned packages:

$ which gpg
/usr/local/bin/gpg
$ ls -l /usr/local/bin/gpg
lrwxr-xr-x 1 user admin 30 Apr 13 21:37 /usr/local/bin/gpg -> ../Cellar/gnupg/2.2.15/bin/gpg
$ gpg --version | head -1
gpg (GnuPG) 2.2.15
$ python test.py
...
RuntimeError: GnuPG is not installed!

Ref #123 #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant