when output is an object with a write method, write directly to it
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I am unable to get most of the tests passing on my machine right now - various issues. I believe the tests I added are accurate, but have not been able to verify them yet myself. I am interested in any feedback/discussion, as this general functionality is pivotal to my needs - but my implementation of it is certainly only one of many possibilities. |
|
@JamesMaroney Regarding the tests, I had similar issues and the recent PR #206 gives a summary of the errors I had. Maybe you can compare the failures you see with mine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
outputis an object implementing awritemethod, pass gpg output directly to it rather than accumulating it in memory.