Fixed problem parsing --list-keys and --list-sigs #159
Conversation
| @@ -1027,6 +1033,9 @@ def sub(self, args): | |||
| subkey = [args[4], args[11]] | |||
| self.curkey['subkeys'].append(subkey) | |||
|
|
|||
| def rvk(self, args): | |||
| self.curuid == None | |||
There was a problem hiding this comment.
I don't see this revocation key packet in your error example at #158.
Why are you reseting the curuid when you find a revocation key?
There was a problem hiding this comment.
I think the revocation packet is on a different UID, at the very end:
rev:::1:C0A2586F09D77C82:1471422777::::heartsucker <[email protected]>:28x:::::10:
But I still don't understand why one would reset curuid…
There was a problem hiding this comment.
My assumption is that this line is a typo, it should be
if self.curuid == None:
return
like in the other lines.
There was a problem hiding this comment.
I don't remember why I reset curuid, but that fixed the problem at the time. I'm trying to get back and understand what I did and why.
There was a problem hiding this comment.
@isislovecruft @meskio Ok, I remember what happened here. In the original issue, I posted the output of what I thought was the key that was causing the problem.
However, the problem (I think) was that the key before the one that was erring out had either a) no subkeys and one revocation cert or b) the last key was revoked. This did something like causing the next key to be parsed to attempt to access a dict member that was based off a key that didn't exist.
Because this was something I was doing at an old job, I don't have access to the key in question to share the output (and it may have changed since then anyway).
|
Heya. Slow response because I'm trying to find the key that caused this error in the first place so I can reliably reproduce this. I'll get back soon (promise). |
Fixes #158