Feat/modal component #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2024 21:47
punchanabu
reviewed
Sep 12, 2024
punchanabu
requested changes
Sep 13, 2024
src/lib/components/Modal.svelte
Outdated
| import { typography } from '../../styles/tailwind/typography'; | ||
| import { faX, faFile } from '@fortawesome/free-solid-svg-icons'; | ||
| import Fa from 'svelte-fa'; | ||
| let isClose = false; |
There was a problem hiding this comment.
เปลี่ยนชื่ออันนี้เป็น isModalOpen ดีกว่าพอเป็น isClose แล้ว logic มันสลับกัน my bad bro
src/lib/components/Modal.svelte
Outdated
| > | ||
| เอกสารที่เกี่ยวข้อง | ||
| </div> | ||
| <button class="hover:scale-105 transition-all" on:click={() => closeModal()}> |
|
When your commit is behind the dev branch, you can update your branch to include the latest changes from dev na krub |
This is how you do it na @Chulinuwu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Sleep
Screenshots or GIFs (if applicable)