Jjnavanon/sucu 46 user get user by #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiraphatys
reviewed
Oct 14, 2024
Comment on lines
+7
to
+8
| bin = "./tmp/main.exe" | ||
| cmd = "go build -o ./tmp/main.exe ./cmd/main.go" |
There was a problem hiding this comment.
ฝากแก้ให้เหมือนเดิมด้วย bro ใน macos มันไม่มี .exe @JJnvn
wiraphatys
reviewed
Oct 14, 2024
| u.logger.Named("GetUserByID").Error(constant.ErrInvalidRole, zap.String("role", req.Role), zap.Error(err)) | ||
| return nil, apperror.ForbiddenError(constant.ErrInvalidRole) | ||
| } | ||
| res_return := dtos.UserDTO{ |
There was a problem hiding this comment.
แก้ชื่อตัวแปรให้เป็น camel ด้วยคับบ like resReturn
| CreatedAt: res.CreatedAt, | ||
| UpdatedAt: res.UpdatedAt, | ||
| } | ||
| return &res_return, nil |
| @@ -43,7 +43,13 @@ func (h *UserHandler) GetAllUsers(c *fiber.Ctx) error { | |||
| // @Failure 500 {object} response.Response | |||
| // @Router /users/{user_id} [get] | |||
| func (h *UserHandler) GetUserByID(c *fiber.Ctx) error { | |||
| return nil | |||
| userID := c.Params("user_id") // how to get this? | |||
Comment on lines
+49
to
+52
| if err != nil { | ||
| return err | ||
| } | ||
| return c.JSON(res) |
There was a problem hiding this comment.
ใช้ package responses เวลา return นะะ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
create get user by id api