chanatpakorn/joh-77-sprint-5-api-pets-info-petsid-query #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
boomchanotai
requested changes
Feb 20, 2024
src/api/getPet.ts
Outdated
There was a problem hiding this comment.
ใส่ function ไว้ที่ไฟล์ api/pets.ts
Comment on lines
15
to
17
| {petData && ( | ||
| <Details isLoading={petDataLoading} isAdmin={true} data={petData} /> | ||
| )} |
There was a problem hiding this comment.
ทำแบบนี้ไปก็ไม่ได้ประโยชน์อะไน เพราะว่ามันรอ petData โหลดเสร็จแล้วค่อย Render ลองดูที่กูเขียนหน้าอื่นๆดู
- ไม่ต้อง
petData && - แล้วไป set props type ให้ data เป็น
Pet | undefined
| {petData && ( | ||
| <Details isLoading={petDataLoading} isAdmin={true} data={petData} /> | ||
| )} | ||
| {data && <SmallPetCardList isLoading={isLoading} pets={data.pets} />} |
Comment on lines
12
to
13
| type: "dog" | "cat" | "-"; | ||
| gender: "male" | "female" | "-"; |
There was a problem hiding this comment.
ลอง cast type ให้มันเป็น dog | cat | - เหมือนเดิมได้ไหม
| @@ -39,7 +43,7 @@ const Details = ({ | |||
|
|
|||
| return ( | |||
| <> | |||
| <BigPetCard isAdmin={isAdmin} /> | |||
| <BigPetCard isLoading={isLoading} isAdmin={isAdmin} data={data} /> | |||
There was a problem hiding this comment.
ไม่ต้อง pass isLoading ไปที่ Details แล้วดิ เพราะว่าให้ Component Details มัน แปะ Fallback แทน
src/components/SmallPetCardList.tsx
Outdated
| pets, | ||
| }: { | ||
| isLoading: boolean; | ||
| pets: Pet[]; |
There was a problem hiding this comment.
เปลี่ยนเป็น pets | undefined
boomchanotai
requested changes
Feb 20, 2024
|
boomchanotai
approved these changes
Feb 20, 2024
ChanatpakornS
deleted the
chanatpakorn/joh-77-sprint-5-api-pets-info-petsid-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QUERY !!!