Feature/joh 12 footer #2
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,54 @@ | ||
| import facebookLogo from "../assets/footer/FacebookLogo.svg"; | ||
| import twitterLogo from "../assets/footer/InstagramLogo.svg"; | ||
| import johnjudLogo from "../assets/footer/JohnJudLogo.svg"; | ||
| import instagramLogo from "../assets/footer/TwitterLogo.svg"; | ||
| console.log(facebookLogo); | ||
| const Footer = () => { | ||
| return ( | ||
| <div className="mt-auto w-full"> | ||
| <div className="relative mx-auto h-[215px] w-full shrink-0 lg:h-[215px]"> | ||
| <div className="relative flex h-full w-full justify-between bg-teal-600 px-[7.63%] py-[6.80%] lg:px-[1.85%] lg:py-[0%]"> | ||
|
There was a problem hiding this comment. ตรงนี้สามารถกำหนด padding สำหรับ หน้าจอ desktop ได้ แทนการใช้ height
|
||
| {/* Text & Logo*/} | ||
| <div className="flex-start inline-flex w-[66%] flex-col justify-start gap-4 lg:w-[55%] lg:flex-row lg:items-center"> | ||
| <div className="mr-12 inline-flex h-[25.61%] items-center justify-start gap-3"> | ||
| <img | ||
| className="h-[42px] w-[42px] rounded-full" | ||
| src={johnjudLogo} | ||
| alt="Johnjud Logo" | ||
| /> | ||
| <div className="text-sm font-bold text-white">JOHNJUD</div> | ||
| </div> | ||
| {/*Text*/} | ||
| <div className="inline-flex flex-col gap-4 lg:w-[458px] lg:gap-3"> | ||
| <div className="w-full p-0 text-xs font-normal leading-[15px] text-white lg:text-[20px] lg:leading-[25px]"> | ||
|
There was a problem hiding this comment. อันนี้ฝากเปลี่ยน lg:text-base หน่อย คิดว่าใช้ font ขนาดธรรมดาน่าจะดูดีกว่า ใน figma ทำไมมันดูสมส่วนก็ไม่รู้ There was a problem hiding this comment. จริงๆ leading ไม่ต้องก็ได้นะ พวก class text-base text-xs มันทำให้หมดละ |
||
| สโมสรนิสิตคณะสัตวแพทยศาสตร์ <br className="gap-3"></br> | ||
| จุฬาลงกรณ์มหาวิทยาลัย ถนน อังรีดูนังต์ แขวงปทุมวัน เขตปทุมวัน | ||
| กรุงเทพ ฯ 10330 | ||
| </div> | ||
| <div className="w-full text-xs font-normal leading-[15px] text-white lg:pr-[5%] lg:text-[20px] lg:leading-[25px]"> | ||
| พัฒนาโดย ฝ่ายพัฒนาระบบสารสนเทศ <br className="gap-3"></br> | ||
| องค์การบริหารสโมสรนิสิตจุฬาลงกรณ์มหาวิทยาลัย | ||
| </div> | ||
| </div> | ||
| </div> | ||
| {/*Social*/} | ||
| <div className="inline-flex flex-col items-center justify-center gap-6"> | ||
|
There was a problem hiding this comment. สงสัยว่าทำไมใช้ inline-flex |
||
| <div className="relative flex items-center justify-center"> | ||
| <img className="h-8 w-8" src={facebookLogo} alt="Facebook Logo" /> | ||
| </div> | ||
| <div className="relative flex items-center justify-center"> | ||
| <img className="h-8 w-8" src={twitterLogo} alt="Instagram Logo" /> | ||
| </div> | ||
| <div className="relative flex items-center justify-center"> | ||
| <img className="h-6 w-6" src={instagramLogo} alt="Twitter Logo" /> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| {/*Only available in less than md */} | ||
| {/*Johnjud*/} | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Footer; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
บรรทัดนี้อ่ะ
h-[215px]กับlg:h-[215px]มันไม่ได้เปลี่ยน responsive อะไรเลยบรรทัดนี้ลบ class ไปหมดเลยก็ได้ แล้วไปกำหนด padding
py-..บรรทัดต่อไปแทน