Multi-objective Fixes #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves several problems in the multi-objective model checking engine.
First of all, it removes a NullPointerException that was thrown for several properties since the variables instance variable was never set in EvaluatorExplicitOperatorShortcutImplies.
Also, infeasible multi-objective properties are reported again.
Lastly, stop-rewards were handed-out for rewards, even though they should only be handed out for probabilistic subproperties. For example, this caused the property multi(R{"time"}min=? [C], R{"energy"}<=43.99999993400001 [C]) on
https://github.com/tquatmann/qcomp23-multi/blob/v1.0/models/rov/rov.prism with constants B=10,Unf=2 and an absolute --graphsolver-iterative-stop-criterion to report a result of -1, even though there are no negative rewards in the model.