Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some versions and installation instructions #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update some versions and installation instructions #12

wants to merge 1 commit into from

Conversation

jessesnyder
Copy link

@jessesnyder jessesnyder commented Mar 23, 2022 •
edited
Loading

Not sure if the python-ldap update is necessary, tbh.

paregorios
paregorios reviewed Mar 23, 2022
View reviewed changes
Copy link
Member

@paregorios paregorios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to me like what was discussed in slack yesterday. I'm not currently equipped to test locally, so perhaps we should have another developer with a working dev environment also test?

alecpm
alecpm approved these changes Mar 23, 2022
View reviewed changes
Copy link

@alecpm alecpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The version pins mostly duplicate the changes from 8daafa1 which I merged to staging earlier, but that's no big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paregorios paregorios paregorios left review comments

@alecpm alecpm alecpm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessesnyder @alecpm @paregorios