Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create group #189

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Create group #189

wants to merge 7 commits into from

Conversation

c-pec
Copy link

@c-pec c-pec commented Apr 13, 2022

Ability to add a new group with existing contacts per ticket #72. I will have a follow up PR for tab completion of contacts name/ number, my plan is to follow this approach from the ticket:

:createGroup group name here query<Tab> lists all the contacts containing the query in the statusbar, like {+123456789 (Contact Name) | +12349876 (Other Contact Name)}. When there is only one completion left, scli inserts (+123456789) Full Contact Name.

Please let me know if you have any input on this approach.

@exquo
Copy link
Collaborator

exquo commented Apr 15, 2022

Thanks!

Feel free to add the tab completion to this PR. We'll need to make sure that it works with contacts' names with spaces.

We should also add the ability to add and remove people from the group. That is pretty integral to the 'group management functionality', if we want to make it part of scli. The same signal-cli's updateGroup command can be used for that.

@c-pec
Copy link
Author

c-pec commented Apr 15, 2022

great thanks, I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants