improve Apple Sentry

irov · Aug 24, 2023 · b5f438d · b5f438d
1 parent 44248fe
commit b5f438d
Show file tree

Hide file tree

Showing 9 changed files with 130 additions and 223 deletions.
diff --git a/src/Plugins/AppleSentryPlugin/AppleSentryApplicationDelegate.mm b/src/Plugins/AppleSentryPlugin/AppleSentryApplicationDelegate.mm
@@ -10,24 +10,21 @@ @implementation AppleSentryApplicationDelegate
 
 #pragma mark - UIKitProxyApplicationDelegateInterface
 
-- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
+- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {   
     NSString * AppleSentryPlugin_DSN = Mengine::Helper::AppleGetBundlePluginConfigString( @("MengineAppleSentryPlugin"), @("DSN"), nil );
 
     if( AppleSentryPlugin_DSN == nil )
     {
         return NO;
     }
 
-    BOOL AppleSentryPlugin_Debug = Mengine::Helper::AppleGetBundlePluginConfigBoolean( @("MengineAppleSentryPlugin"), @("Debug"), NO );
-
     const Mengine::Char * BUILD_VERSION = Mengine::Helper::getBuildVersion();
 
     [SentrySDK startWithConfigureOptions:^(SentryOptions *options) {
         options.dsn = AppleSentryPlugin_DSN;
-        options.debug = AppleSentryPlugin_Debug; // Enabled debug when first installing is always helpful
+        options.debug = MENGINE_DEBUG_VALUE(YES, NO); // Enabled debug when first installing is always helpful
+        options.environment = MENGINE_BUILD_PUBLISH_VALUE(@"production", @"debug");
         options.releaseName = @(BUILD_VERSION);
-        options.attachStacktrace = true;
-        options.tracesSampleRate = @(1.0);
     }];
 
     return YES;

diff --git a/src/Plugins/AppleSentryPlugin/AppleSentryHelper.h b/src/Plugins/AppleSentryPlugin/AppleSentryHelper.h
diff --git a/src/Plugins/AppleSentryPlugin/AppleSentryHelper.mm b/src/Plugins/AppleSentryPlugin/AppleSentryHelper.mm
diff --git a/src/Plugins/AppleSentryPlugin/AppleSentryLoggerCapture.mm b/src/Plugins/AppleSentryPlugin/AppleSentryLoggerCapture.mm
@@ -1,11 +1,12 @@
 #include "AppleSentryLoggerCapture.h"
-#include "AppleSentryHelper.h"
 
 #include "Kernel/ConfigHelper.h"
 #include "Kernel/LoggerHelper.h"
 
 #include "Config/StdString.h"
 
+#import <Sentry/Sentry.h>
+
 namespace Mengine
 {
     //////////////////////////////////////////////////////////////////////////
@@ -43,7 +44,7 @@
 
         MENGINE_STRNCAT( buffer, data_str, data_size );
 
-        Helper::appleSentryMessageCapture( buffer );
+        [SentrySDK captureMessage:@(buffer)];
     }
     //////////////////////////////////////////////////////////////////////////
 }
diff --git a/src/Plugins/AppleSentryPlugin/AppleSentryPlugin.mm b/src/Plugins/AppleSentryPlugin/AppleSentryPlugin.mm
@@ -58,7 +58,7 @@
     }
     //////////////////////////////////////////////////////////////////////////
     void AppleSentryPlugin::_finalizePlugin()
-    {
+    {        
         SERVICE_FINALIZE( AppleSentryService );
     }
     //////////////////////////////////////////////////////////////////////////

diff --git a/src/Plugins/AppleSentryPlugin/AppleSentryService.h b/src/Plugins/AppleSentryPlugin/AppleSentryService.h
@@ -19,7 +19,7 @@ namespace Mengine
 
     public:
         bool _initializeService() override;
-        void _finalizeService() override;
+        void _finalizeService() override;  
 
     protected:
         void notifyCreateApplication_();