Extensive reformatting (e.g. PEP8) #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply extensive reformatting in regard to code style and syntax. Mostly PEP8 changes (e.g. snake case for functions and variable names. Also clean up some dead code. Switch from _thread to public API.
|
@ironsheep "ping" :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the holidays I set up Home Assistant and then stumbled over this nice project.
When looking into the code I noticed a few inconsistencies and also that several of the Python "conventions" (PEP8, camel case and so on) that I'm familiar with are not strictly followed.. ;-D
I did put in the effort to do some refactoring.
I can not with 100% certainty say that nothing broke - but I'm running my modified code on three different Raspberry Pi's and it appears to be sending the exact same data.
@ironsheep would you even consider merging this (either as one big commit - or split into individual blocks of changes)?
Line 1000 contains a change that turns a problem with accessing
/dev/vciofrom a crash into a warning (see also: #94 + #98).