Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in handling of ignored errors #99

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Change in handling of ignored errors #99

merged 6 commits into from
Sep 27, 2023

Conversation

vlorinc
Copy link
Contributor

@vlorinc vlorinc commented Sep 26, 2023

Implemented changes from library net-dpservice-go.
Ignored errors can now be directly passed as argument to dpservice gRPC functions as []int32 and nil error is returned if they are matched or there was no error.
Previously used function IgnoreStatusErrorCode is still available.

Library was updated to current version v0.1.18.

@vlorinc vlorinc added the enhancement New feature or request label Sep 26, 2023
@vlorinc vlorinc requested a review from guvenc September 26, 2023 12:35
@vlorinc vlorinc self-assigned this Sep 26, 2023
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@guvenc guvenc merged commit d3d743f into main Sep 27, 2023
7 of 9 checks passed
@guvenc guvenc deleted the update/ignored_errors branch September 27, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants