Get multiport-eswitch mode from metalnet rundir #270
Conversation
There was a problem hiding this comment.
Looks no issue to me. But it would be nice to have one line comment like: run touch /var/run/metalnet/mode && echo -n "eswitch" > /var/run/metalnet/mode to enable multiport eswitch mode, as this approach of configuration is not so crystal clear it is a manual step to setup the flag.
PlagueCZ
force-pushed
the
feature/multiport_mode_detection
branch
from
e7c6708
to
4463703
Compare
github-actions
bot
added
size/S
documentation
|
I added a comment and also some documentation in README.md covering multiport-eswitch and pf1-proxy |
PlagueCZ
force-pushed
the
feature/multiport_mode_detection
branch
from
4463703
to
e193110
Compare
|
I have reverted the removal of |
main.go
Outdated
| @@ -104,7 +104,7 @@ func main() { | |||
| flag.BoolVar(&enableIPv6Support, "enable-ipv6", false, "Enable IPv6 support") | |||
| flag.IntVar(&publicVNI, "public-vni", 100, "Virtual network identifier used for public routing announcements.") | |||
| flag.IPVar(&routerAddress, "router-address", net.IP{}, "The address of the next router.") | |||
| flag.BoolVar(&multiportEswitchMode, "multiport-eswitch", false, "Enable multiport eswitch support") | |||
| flag.BoolVar(&multiportEswitchMode, "multiport-eswitch", false, "Enable multiport eswitch support (unless specified in metalnet-dir)") | |||
There was a problem hiding this comment.
maybe 'Enale multiport eswitch support explicitly, unless specified in metalnet-dir' is a bit more understandable?
There was a problem hiding this comment.
Well arguments are already explicit, but then we would say "explicit unless" which is strange, so how about changing the parentheses to "(file in metalnet-dir can override this)"?
There was a problem hiding this comment.
I have reworded the help and also changed the handling so it should work normally when the metalnet-dir file is not present
PlagueCZ
force-pushed
the
feature/multiport_mode_detection
branch
from
e193110
to
c5ebb2c
Compare
In OSC it is beneficial to use the same metalnet deployment for both versions of dpservice - legacy (single-port) and multiport-eswitch ones.
Thus using the command-line argument is not the way to go, instead we simply
echo -n "eswitch" > /var/run/metalnet/modeand metalnet then reads this information, just like it gets other stuff from virtlet(?) about VFs.The original implementation in 78efc7c is tested in our clusters, I simplified the code without being able to run it in a cluster, though I did verify the output locally.