Github Actions Test #100
Merged
Github Actions Test #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
enhancement
damyan
force-pushed
the
feature/test_github_actions
branch
2 times, most recently
from
c209721
to
2c87999
Compare
Signed-off-by: Guvenc Gulce <[email protected]>
- remove redundant `check` target - run `go fmt` from the `check` target - do not check for license header when running `make test`, use the `check` target instead - do not add license header when building, use the `check` target instead
`setup-git-redirect.sh` is needed for tests, because go needs SSH authentication, when downloading modules dependencies. The redirect script, though, does not revert the global changes done to the git config (in that case: SSH instead of HTTPS). The `checkout` action, on the other hand, needs the HTTPS for checkout, because the SSH key at the beginning of the action is no longer available, it was properly cleaned up in the `webfactory/ssh-agent` post clean up. Implementing workaround as in webfactory/ssh-agent#184
Delete the global git config after lint and test, so we always start the checkout without URL redirection. See previous commit for details
- kill metalbond - stop all docker containers
guvenc
force-pushed
the
feature/test_github_actions
branch
from
2c87999
to
8dae25e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.