Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling of Reset ad-hoc operation to Server type #125

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Add handling of Reset ad-hoc operation to Server type #125

merged 5 commits into from
Sep 13, 2024

Conversation

stefanhipfel
Copy link
Contributor

@stefanhipfel stefanhipfel commented Sep 12, 2024 •
edited
Loading

very simple implementation, which does not check if the reset api call to the bmc was successful or not.

future improvements:
use Conditions and redfish Events to track the progress of a reset call

@stefanhipfel stefanhipfel linked an issue Sep 12, 2024 that may be closed by this pull request
Support Ad-hoc Operations for Server Management #77
Closed
afritzler
afritzler requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefanhipfel. Just some minor things.

internal/controller/server_controller.go Show resolved Hide resolved
internal/controller/server_controller.go Outdated Show resolved Hide resolved
@afritzler afritzler changed the title implements adhoc operations First implements of adhoc operations Sep 13, 2024
@afritzler afritzler added the enhancement New feature or request label Sep 13, 2024
@afritzler
Copy link
Member

Do we also want to ad this ad-hoc handling to the ServerClaim? That way a user can powercycle the Server he claimed as he has typically no RBAC to modify the Server annotations directly.

@stefanhipfel
Copy link
Contributor Author

Do we also want to ad this ad-hoc handling to the ServerClaim? That way a user can powercycle the Server he claimed as he has typically no RBAC to modify the Server annotations directly.

I think so yes, but we should restrict the operations a user can do

@afritzler afritzler changed the title First implements of adhoc operations Add handling of Reset ad-hoc operation to Server type Sep 13, 2024
@afritzler
Copy link
Member

Fair point. Lets keep this PR for Server operations only this feature for ServerClaims later.

@afritzler afritzler merged commit 2e561dd into main Sep 13, 2024
9 checks passed
@afritzler afritzler deleted the adhoc_operations branch September 13, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Ad-hoc Operations for Server Management
2 participants
@stefanhipfel @afritzler