Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingition secret name length issue #418

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

ushabelgur
Copy link
Contributor

Proposed Changes

  • Creating the Ignition secret with the same name as the Machine name
  • For backward compatibility checking if ignition secret was already present with old naming convention before creating/deleting with new name

Fixes #417

@github-actions github-actions bot added size/M bug Something isn't working provider labels Sep 12, 2024
@ushabelgur ushabelgur marked this pull request as ready for review September 12, 2024 06:12
@ushabelgur ushabelgur requested a review from a team as a code owner September 12, 2024 06:12
@afritzler afritzler merged commit 05a6d56 into main Sep 12, 2024
8 checks passed
@afritzler afritzler deleted the fix/ignition_secret_name branch September 12, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working provider size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignition secret name too long
2 participants