Fix NetworkInterface status propagation for IPs
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
force-pushed
the
fix/nic-status-ips
branch
2 times, most recently
from
1ec2511
to
a7233eb
Compare
afritzler
force-pushed
the
fix/nic-status-ips
branch
from
a7233eb
to
cb5a63f
Compare
afritzler
force-pushed
the
fix/nic-status-ips
branch
from
cb5a63f
to
fdf2792
Compare
afritzler
force-pushed
the
fix/nic-status-ips
branch
from
fdf2792
to
bee2f08
Compare
lukas016
reviewed
Feb 7, 2024
|
|
||
| log.V(1).Info("Host device is ready", "HostDevice", hostDev) | ||
| nicIPs := make([]net.IP, 0, len(apinetNic.Spec.IPs)) | ||
| nicIPs := make([]string, 0, len(apinetNic.Spec.IPs)) | ||
| for _, apinetNicIP := range apinetNic.Spec.IPs { | ||
| // TODO: do proper IP type conversion here |
There was a problem hiding this comment.
do you need still this comment?
| } | ||
| log.V(1).Info("Host device is ready", "HostDevice", hostDev, "IPs", nicIPs) |
There was a problem hiding this comment.
do you think it is good idea log whole structure hostDev and maybe IPs too, how it can help ops guys? Or maybe different level as info, if you need it.
|
Let's put this one on hold for now as I wanted to do some further testing. I will mark shit PR as draft for now and mark them as ready later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix
NetworkInterfacestatus propagation for IPs:[]stringfor IPs inNetworkInterfacestatus