Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade k8s Dependencies to v0.30.4 & controller-runtime to v0.18.5 #338

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sujeet01
Copy link
Contributor

This PR upgrades our Kubernetes package dependencies from v0.29.4 to v0.30.4 and implements necessary code refactoring to accommodate breaking changes.

Proposed Changes:

  • Upgrade K8s Dependencies: Bumped k8s.io/* dependencies from v0.29.9 to v0.30.4 to incorporate the latest features and improvements. Fixes #1113
  • Upgrade Controller-Runtime: Bumped sigs.k8s.io/controller-runtime from v0.17.6 to v0.18.5 to ensure compatibility with the upgraded k8s dependencies.
  • Refactor for Breaking Changes: Adjusted code to address breaking changes introduced in the new version.
  • Update Code Generation Script: Adapted hack/update-codegen.sh script to utilize the kube_codegen.sh script functions, aligning with updated k8s code generation standards.
  • Update OpenAPI-Gen Package: The openapi-gen has been removed from k8s.io/code-generator by PR #123529 because it is redundant with the version in k8s.io/kube-openapi.
  • Update Makefile: Updated ENVTEST_K8S_VERSION from 1.28.0 to 1.30.3 and performed cleanup by removing obsolete generation tool binaries.
  • Run Make Generate: Executed make generate to apply all code generation tasks with the updated setup.
  • Update Import Paths: Updated import paths to match the new locations of the generated client code.

@sujeet01 sujeet01 self-assigned this Nov 11, 2024
@sujeet01 sujeet01 requested a review from a team as a code owner November 11, 2024 08:59
@sujeet01 sujeet01 marked this pull request as draft November 11, 2024 09:10
@lukas016 lukas016 force-pushed the osc/enh-k8s-upgrade-30.4 branch 2 times, most recently from c4d133a to e8a5278 Compare November 11, 2024 10:58
@sujeet01 sujeet01 marked this pull request as ready for review November 11, 2024 11:17
- Refactor code to handle breaking changes
- Run make generate to regenerate code
- Update import paths for compatibility
@afritzler afritzler added the enhancement New feature or request label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants