Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SecretRef to IgnitionConfig #78

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Add SecretRef to IgnitionConfig #78

merged 3 commits into from
Nov 15, 2024

Conversation

defo89
Copy link
Contributor

@defo89 defo89 commented Nov 13, 2024

Proposed Changes

  • allow to provide ignition config via Secret
  • Raw and Secret content are merged together

Fixes #75

@defo89 defo89 added the enhancement New feature or request label Nov 13, 2024
@defo89 defo89 requested a review from a team as a code owner November 13, 2024 09:43
@github-actions github-actions bot added size/M api-change controllers documentation Improvements or additions to documentation labels Nov 13, 2024
@defo89 defo89 changed the title Add IgnitionSecretRef to IgnitionConfig Add IgnitionSecret to IgnitionConfig Nov 13, 2024
@defo89 defo89 force-pushed the enh/ignition-secret branch 2 times, most recently from 89ef9f3 to 3377b6c Compare November 13, 2024 09:54
pkg/apis/metal/v1alpha1/types_worker.go Outdated Show resolved Hide resolved
pkg/controller/worker/machines.go Outdated Show resolved Hide resolved
pkg/controller/worker/machines.go Outdated Show resolved Hide resolved
pkg/controller/worker/machines.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/L and removed size/M labels Nov 13, 2024
@defo89 defo89 changed the title Add IgnitionSecret to IgnitionConfig Add SecretRef to IgnitionConfig Nov 13, 2024
@defo89 defo89 merged commit 6498328 into main Nov 15, 2024
7 checks passed
@defo89 defo89 deleted the enh/ignition-secret branch November 15, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change controllers documentation Improvements or additions to documentation enhancement New feature or request size/L
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support Secret reference in Worker extraIgnition
3 participants