Bump github.com/gardener/[email protected]
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/L
api-change
controllers
enhancement
afritzler
commented
Oct 9, 2024
| @@ -3,3 +3,4 @@ bgp: | |||
| nodeToNodeMeshEnabled: false | |||
| listenPort: 179 | |||
| bindMode: NodeIP | |||
| asNumber: true | |||
There was a problem hiding this comment.
@defo89 would such a default value make sense here?
There was a problem hiding this comment.
not really, it's BGP autonomous system number which will be specific to the infrastructure. But we could use Calico default 64512 here
There was a problem hiding this comment.
Thanks! I changed the value to 64512. The issue was that the helm check is expecting that all required values are set in the values.yaml.
afritzler
force-pushed
the
enh/gardener-103
branch
from
8f855a1
to
02923df
Compare
afritzler
force-pushed
the
enh/gardener-103
branch
from
02923df
to
3444ef8
Compare
Nuckal777
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
github.com/gardener/[email protected]