Add missing neighnat rollback and increase SNAT/DNAT table size #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlagueCZ
force-pushed
the
fix/neighnat_rollback
branch
from
1feffe3
to
78f0070
Compare
|
As discussed with @byteocean I increased the table size more and put an explanation next to it. There was a suggestion to remove errorcheck in neighnat deletion, which I like, but I think that the "non existing" error should still be reacted to as to not perform a task when the user sends a bad argument over gRPC. |
guvenc
reviewed
Dec 5, 2023
guvenc
approved these changes
Dec 5, 2023
byteocean
approved these changes
Dec 6, 2023
|
@PlagueCZ Could you please rebase ? Thanks. |
PlagueCZ
force-pushed
the
fix/neighnat_rollback
branch
from
78f0070
to
be3da49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the linked issue, missing rollback was preventing the cleanup and subsequent reuse of a NAT/VIP IP address.
As this came to be because of OSC running out of available entries in DNAT table (without that situation this bug cannot be reproduced), I also increased the table capacity from 100 to 256.
There is a pytest to demonstrate the problem in test/neighnat_rollback
Fixes #447