dp_flow flags rename #435
Merged
dp_flow flags rename #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlagueCZ
commented
Nov 20, 2023
PlagueCZ
commented
Nov 20, 2023
|
|
||
| uint8_t aged : 2; | ||
|
|
||
| bool aged; |
There was a problem hiding this comment.
I removed the bit sizes because those usually make the code slower (unaligned access, masking, ...).
Now if this structure needs to be small (I did not find a reason for it to be), then I will put the sizes back, though the structure needs some changes to make them effective (for example merge pf0, pf1 and aged to a byte, etc.
PlagueCZ
force-pushed
the
feature/dp_flow_flags_rename
branch
from
806e14a
to
7eef0a4
Compare
byteocean
reviewed
Nov 21, 2023
PlagueCZ
force-pushed
the
feature/dp_flow_flags_rename
branch
from
10e8c74
to
edafa09
Compare
guvenc
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there are a few bitfield-type variables in
dp_flow(which makes sense as this is actually stored in the packet space), but these are calledflagseven though they are not flags, but enums.So I moved them out of the structure (made sure the bitfield still works) and put the right types to them. I also moved
nxt_hopto a better-aligned place.This also lead to some connected refactorings (mentioned in notes below)