Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken pytest attach and use less mbufs #433

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Fix broken pytest attach and use less mbufs #433

merged 2 commits into from
Nov 17, 2023

Conversation

guvenc
Copy link
Collaborator

@guvenc guvenc commented Nov 17, 2023

Fix broken pytest attach and use less mbufs for testing as some test VMs may not have enough memory. (like my local VM :) )

@github-actions github-actions bot added bug Something isn't working size/XS labels Nov 17, 2023
@guvenc guvenc requested a review from PlagueCZ November 17, 2023 11:16
PlagueCZ
PlagueCZ approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@PlagueCZ PlagueCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.
Pool size works for me also.

@guvenc guvenc merged commit 2049848 into main Nov 17, 2023
7 checks passed
@guvenc guvenc deleted the fix/pytest_attach branch November 17, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlagueCZ PlagueCZ PlagueCZ approved these changes

Assignees
No one assigned
Labels
bug Something isn't working size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guvenc @PlagueCZ