Improved graphtrace #396
Merged
Improved graphtrace #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlagueCZ
commented
Sep 25, 2023
tools/dp_graphtrace/dp_graphtrace.c
Outdated
| // try to also handle most of the rest (some are not possible, like KILL) | ||
| for (int i = 1; i < _NSIG; ++i) | ||
| signal(i, signal_handler); | ||
|
|
There was a problem hiding this comment.
@guvenc Can you take a look at this block? We at least need to add SIGPIPE for dp_graphtrace|head etc., but it would be safer to handle all signals.
But I was unable to find a better solution than to just iterate like this. But then some signals cannot be handled.
So I could either exhaustively add them with a check, or just make sure the essential ones are setup and leave the rest to chance?
There was a problem hiding this comment.
Hah actually not that good an idea, as SIGSEGV will get caught in there too. I guess we just need to add exhaustively those that can be encountered in operations...
PlagueCZ
force-pushed
the
feature/improved_graphtrace
branch
3 times, most recently
from
ff8e4b3
to
2d4da81
Compare
github-actions
bot
added
size/XXL
documentation
PlagueCZ
force-pushed
the
feature/improved_graphtrace
branch
4 times, most recently
from
6ae80b5
to
8f4eaa5
Compare
PlagueCZ
force-pushed
the
feature/improved_graphtrace
branch
from
8f4eaa5
to
c2137af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we started using it in operations, I did some improvements on the graphtrace tool:
dp_graphtrace | headordp_graphtrace | grep)Graphtrace successfully disabled in dp-servicetostderr(because stdout will be grepped often)--stopto at least have a way to stop manually (e.g. for when the above message is not confirmed)PORT ## >> rxandtx >> PORT ##by default--dropsto log also dropped packets (to match them toPORT ## >> rxwhen there is notx >> PORT--nodesto log the full graph traversal like the original tool diddpservice-dumpas discussed. The rest of the renaming is part of Update DPDK to 22.11 #385dp_conf_generate.pythat can now easily serve multiple tools and (non-generated) code duplication is minimized.Stuff left for the followup PR:
Unfortunately the
dp_conf_generate.pychange is the most verbose in diffs, but going by commits you can just skim that part.