Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vf offload dump draft #371

Merged
merged 11 commits into from
Sep 22, 2023
Merged

vf offload dump draft #371

merged 11 commits into from
Sep 22, 2023

Conversation

byteocean
Copy link
Contributor

@byteocean byteocean commented Sep 5, 2023

This draft PR proposed changes to perform pkt dumping on VF when offloading is enabled. It is going to replicate the pkts coming from VMs and send them to the (local) graphtrace tool. Due to the hw limitation, it is not yet possible to mark replicated pkts so as to immediately identify the incoming pkts on the SW path. This decision is done in cntrack, and until that time it is possible to identify those replicated pkts. Extra information in the graphtrace is used to help users to identify replicated pkts' trace.

starting dp_graphtrace with option --hw-packet dumps packets from VF, in case VM is not accessible

@github-actions github-actions bot added size/L enhancement New feature or request labels Sep 5, 2023
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
src/rte_flow/dp_rte_flow_init.c Show resolved Hide resolved
src/rte_flow/dp_rte_flow_init.c Outdated Show resolved Hide resolved
src/nodes/rx_node.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
include/rte_flow/dp_rte_flow_helpers.h Outdated Show resolved Hide resolved
include/monitoring/dp_graphtrace_shared.h Outdated Show resolved Hide resolved
include/monitoring/dp_graphtrace.h Outdated Show resolved Hide resolved
src/dp_port.c Outdated Show resolved Hide resolved
src/dp_port.c Outdated Show resolved Hide resolved
Copy link
Contributor

@PlagueCZ PlagueCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The async hw tracing start event looks even simpler that I thought it would be, nice.

src/rte_flow/dp_rte_flow_init.c Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/XL and removed size/L labels Sep 7, 2023
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
include/monitoring/dp_graphtrace.h Outdated Show resolved Hide resolved
src/dp_port.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
Copy link
Contributor

@PlagueCZ PlagueCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use the same approach as before, where the main work is done, and I can take care of the tedious nitpicking in my separate commit?

tools/dp_graphtrace.c Outdated Show resolved Hide resolved
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
@byteocean byteocean force-pushed the feature/vf_offload_dump_draft branch 2 times, most recently from 31f6601 to 3d9a1db Compare September 11, 2023 09:35
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
tools/dp_graphtrace.c Show resolved Hide resolved
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
@byteocean byteocean force-pushed the feature/vf_offload_dump_draft branch 2 times, most recently from c54a957 to 26213bb Compare September 11, 2023 13:36
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Show resolved Hide resolved
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
tools/dp_graphtrace.c Show resolved Hide resolved
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
src/dp_cntrack.c Outdated Show resolved Hide resolved
Copy link
Contributor

@PlagueCZ PlagueCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running this and (apart from small warnings), it actually segfaults for --hw option, software works fine. Happens for both --no-offload and with offlosing on dp-service

src/rte_flow/dp_rte_flow_init.c Show resolved Hide resolved
tools/dp_graphtrace.c Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Show resolved Hide resolved
tools/dp_graphtrace.c Show resolved Hide resolved
tools/dp_graphtrace.c Show resolved Hide resolved
tools/dp_graphtrace.c Show resolved Hide resolved
tools/dp_graphtrace.c Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
tools/dp_graphtrace.c Outdated Show resolved Hide resolved
@byteocean byteocean force-pushed the feature/vf_offload_dump_draft branch 3 times, most recently from 4e47bb1 to 6690e5a Compare September 13, 2023 14:22
@byteocean byteocean marked this pull request as ready for review September 13, 2023 14:23
tools/dp_graphtrace.c Show resolved Hide resolved
tools/dp_graphtrace.c Show resolved Hide resolved
tools/dp_graphtrace.c Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
@byteocean byteocean force-pushed the feature/vf_offload_dump_draft branch 2 times, most recently from 61f4f9d to 28f785f Compare September 15, 2023 14:25
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
src/monitoring/dp_graphtrace.c Outdated Show resolved Hide resolved
@byteocean byteocean force-pushed the feature/vf_offload_dump_draft branch 4 times, most recently from 6b32ae3 to 8758ab4 Compare September 18, 2023 09:43
src/dp_port.c Show resolved Hide resolved
src/dp_port.c Show resolved Hide resolved
@guvenc guvenc merged commit 3de5709 into main Sep 22, 2023
7 checks passed
@guvenc guvenc deleted the feature/vf_offload_dump_draft branch September 22, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants