Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix makefile goimports target #75

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Fix makefile goimports target #75

merged 2 commits into from
Jun 28, 2024

Conversation

damyan
Copy link
Member

@damyan damyan commented Jun 28, 2024

Missing GOIMPORTS and GOIMPORTS_VERSION variables leads to a silently failing goimport target, as well as all its reverse dependency targets. Example:

make fmt

w .
12:01  up 1 day, 40 mins, 6 users, load averages: 4.14 2.66 2.51
USER       TTY      FROM    LOGIN@  IDLE WHAT```

@damyan
Fix makefile goimports target
e4b2fab 
Missing `GOIMPORTS` and `GOIMPORTS_VERSION` variables leads to a
silently failing goimport target, as well as all its reverse dependency
targets. Example:
```
make fmt
w .
11:58  up 1 day, 37 mins, 6 users, load averages: 1.40 1.74 2.26
USER       TTY      FROM    LOGIN@  IDLE WHAT```
@damyan damyan requested a review from hardikdr June 28, 2024 10:02
@damyan damyan enabled auto-merge (squash) June 28, 2024 10:08
@hardikdr hardikdr disabled auto-merge June 28, 2024 13:16
@hardikdr hardikdr merged commit 9a07bbb into main Jun 28, 2024
6 checks passed
@hardikdr hardikdr deleted the fix/fix-fmt-make-target branch June 28, 2024 13:17
@afritzler afritzler added the chore label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damyan @hardikdr @afritzler