Add the ability to fetch remote files (s3 and http[s]) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZJONSSON
changed the title
ZJONSSON
force-pushed
the
remote-files
branch
2 times, most recently
from
bdb76c1 to
792c289
Compare
|
Added the ability to read directly from buffer containing the whole parquet file |
|
LGTM |
|
@ZJONSSON let's add tests if you have the time, if not let us know and we'll try to do it |
|
I agree. To keep tests as unit tests we would have to add a couple of things to the
A test for the buffer reader does not require any additional dependencies |
Adapters included for S3 files and files available over http(s)
Instantiating a new client blocks on retrieving filesize. But there are cases when we really don't need the filesize, for example when we have the metadata cached already.
ZJONSSON
force-pushed
the
remote-files
branch
from
4f5ad32 to
e3c70df
Compare
|
what is the status of this? abandoned? |
|
@Kosta-Github it's not abandoned but we're (mainly me) are having problem allocating time for this project, since the initial effort of building it. If you want to contribute, let's discuss :-) |
jeffbski-rga
pushed a commit
to jeffbski/parquetjs
that referenced
this pull request
Mar 2, 2020
Allow MAP and LIST (for athena/hive)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapters included for S3 files and files available over http(s). Only the parts if interest are fetched over the wire, eliminating the need to download the complete files. The performance of the adapters when fetching full rows is drastically improved with #33
No tests so far, but if you are happy with the approach we could add tests using a simple localhost server and an S3 compatible local service, if that makes sense?