-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#584] load settings from environment without a config file present #585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. Does it make sense to include a test for this?
It does indeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks good to me. Had a couple of fortification suggestions and then I think this should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last thing about that skip and I'm happy with it
Responding to #585 (comment) @alanking 's comment. above (Sorry I cannot respond int eh conversation above, but I guess GitHub works in strange ways.) The
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's get this squashed, @d-w-moore. Omit #s for now.
Squashed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# it
Done. |
See issue description. Basically this change means that you won't have to declare a config file path in the environment (even if that value is null length, denoting the default path of
~/.python_irodsclient
) in order to get the environmental overrides to work.