[2216] Updated README.md for troubleshooting checksum read request rate errors (4-3-stable) #2217
Conversation
There was a problem hiding this comment.
Looks good to me. Let's get another approval before we merge. Also, I suppose we should actually merge the feature before this, too. Also-also, would we have to wait for iRODS 4.3.4 and 4.3.4.0 of this plugin before merging this, since it wouldn't be true until both were released? Hmm...
There was a problem hiding this comment.
Also, I suppose we should actually merge the feature before this, too.
Agreed.
Also-also, would we have to wait for iRODS 4.3.4 and 4.3.4.0 of this plugin before merging this, since it wouldn't be true until both were released? Hmm...
That's correct. Let's get this PR to a merge-able point and leave it open until we know what iRODS 4.3.4 looks like. Once this PR is ready, we cherry-pick and merge it into the main branch.
So ...
- Polish this PR for approval, but do not merge.
- Cherry-pick and merge into the main branch.
|
Looks like this can be squashed (no pounds) and cherry-picked to 4-3-stable. |
JustinKyleJames
force-pushed
the
issue_2216
branch
from
f516289 to
d1c88a0
Compare
I think you meant to main. I squashed and cherry-picked to main. Will open a PR for it. |
korydraughn
changed the title
|
Yes, that's what I meant. |
Is it ready for pounding? |
|
The plan is to cherry-pick this to main and merge it there but hold on this one until we're closer to releasing 4.3.4. See #2217 (review). The idea - I think - is that we don't want to advertise the feature when the server version supplying said feature has not yet been released. Alternatively, we can merge now and hope that users view the README for the specific release tag they are using. |
|
What @alanking has explained is correct. Please cherry-pick this work to the main branch and we'll merge that. We'll keep this PR open until we're closer to a 4.3.4 release. |
This change must be applied to 4.3.4.0 (not 4.3.3.1) since the new setting is not valid without the corresponding updates to iRODS.