Issue 2146 main #2159
Merged
Issue 2146 main #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
trel
reviewed
Jan 10, 2024
trel
reviewed
Jan 10, 2024
trel
reviewed
Jan 10, 2024
|
At the moment we don't have an automated way of running these tests in a topology environment. We need to make sure testing of this plugin in that type of environment is enforced following the merging of this PR. |
alanking
reviewed
Jan 10, 2024
|
clang-format and trailing whitespace good good |
|
Note that after the latest changes I re-ran all tests and they passed. |
|
ready for squashing, no pounds |
JustinKyleJames
force-pushed
the
issue_2146_2
branch
from
16cf37c to
e897d3d
Compare
|
issue numbers and content split look good to me. let's wait on one more vote. |
korydraughn
approved these changes
Jan 10, 2024
JustinKyleJames
force-pushed
the
issue_2146_2
branch
from
e897d3d to
a235567
Compare
Done |
trel
approved these changes
Jan 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2146. All tests passed.
In addition, I added two general test cases to test switching archive naming policy consistent->decoupled and decoupled->consistent after object had already been created. These were added for the following reasons:
See 03eb431 which fixes the scenario I was trying to fix with the open flags. I am now checking the openType. This is now working as expected.