Skip to content

Commit

Permalink
[2146] Code review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
JustinKyleJames committed Jan 10, 2024
1 parent db20999 commit 475a161
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions s3/s3_operations.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ namespace irods_s3 {
const auto s3_key_name = fmt::format("/{}/{}/{}", bucket_name, obj_id, object_name);

// Update physical path but only on first creation otherwise the policy that was in effect
// at the time the object was first created rules.
// at the time the object was first created wins.
if (L1desc[index].openType == CREATE_TYPE) {
logger::debug("{}:{} ({}) [[{}]] updating physical_path to {}",
__FILE__, __LINE__, __FUNCTION__, thread_id, s3_key_name.c_str());
Expand Down Expand Up @@ -2271,8 +2271,9 @@ namespace irods_s3 {

// Must update the physical_path in the L1desc[] table for decoupled naming.
// In the case of a redirect, this runs on the original connected server and this
// is the server that updates the database. This will open update for creates.
// Anything else uses whatever was previously in the database.
// is the server that updates the database. In update_physical_path_for_decoupled_naming,
// the update will only happen if it is a create. Anything else uses whatever was
// previously in the database.
update_physical_path_for_decoupled_naming(_ctx);
}
return SUCCESS();
Expand Down

0 comments on commit 475a161

Please sign in to comment.