Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[irods/irods#7265] Minor reorganization + CMake TLC (4-3-stable) #265

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[irods/irods#7265] Minor reorganization + CMake TLC (4-3-stable) #265

merged 1 commit into from
Mar 13, 2024

Conversation

SwooshyCueb
Copy link
Member

In service of irods/irods#7265

korydraughn
korydraughn approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Let's get one more approval before pounding.

alanking
alanking approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks identical to me. # it.

@SwooshyCueb
[irods/irods#7265] Minor reorganization + CMake TLC
3d4cbff 
- Project tree structure reorganized to resemble that of main irods repo.
- Added quotes around paths in CMake files.
- Removed CMAKE_SHARED_LINKER_FLAGS_INIT and
  CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built.
- Changed all instances of CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR.
- Removed unneeded libarchive include dir
- Removed unneeded fmt linkage
- Removed unneeded libcrypto linkage
- Removed unneeded Threads::Threads linkage
- Added include guard to data_verification_utilities.hpp
- Added include guard to exec_as_user.hpp
- Added include guard to utilities.hpp
@SwooshyCueb
Copy link
Member Author

#'d

@alanking alanking merged commit 2fee1a5 into irods:4-3-stable Mar 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanking alanking alanking approved these changes

@korydraughn korydraughn korydraughn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwooshyCueb @korydraughn @alanking