Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make classpath robustly platform independent #5

Closed
wants to merge 1 commit into from

Conversation

paulschwarz
Copy link

The current implementation fails on Windows. This pull request solves the issue based on:

https://stackoverflow.com/a/17870390/2694806

Copy link
Owner

@irobertson irobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't compile - needs imports:

import java.net.URI;
import java.net.URISyntaxException;
import java.net.URL;
import java.nio.file.Paths;

@paulschwarz
Copy link
Author

Oops, I'm sorry about that.

I've noticed another issue. My solution uses java.nio.file.Paths which is available from Java 1.7, but your project is set to 1.6.

I seem to be going down the rabbit hole here. I've also got tests failing with "Mockito can only mock visible & non-final classes."

@irobertson
Copy link
Owner

I would think that updating this to require java 1.8 would be completely reasonable at this point.

@paulschwarz
Copy link
Author

Ignore and see #6 instead.

#6 does not completely replace this PR, but it's the foundation of moving to Java 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants