Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Make ROS 2 nodes "composable" #59

Open
suo235 opened this issue Nov 15, 2024 · 0 comments
Open

Suggestion: Make ROS 2 nodes "composable" #59

suo235 opened this issue Nov 15, 2024 · 0 comments

Comments

@suo235
Copy link

suo235 commented Nov 15, 2024

Overview

In ROS 2, it is recommended that we write a node like a nodelet of ROS 1. Please refer to https://docs.ros.org/en/jazzy/Concepts/Intermediate/About-Composition.html .
I am ready to commit necessary changes for this suggestion.

Target branch

eloquent-devel

Note

We need to add one line to the top-level CMakeLists.txt of iris_lama to build the package.

# install location of generated cmake config files
set(ConfigPackageLocation ${CMAKE_INSTALL_LIBDIR}/${CMAKE_PROJECT_NAME}/cmake)

# dependencies
find_package(Eigen3 3.3 REQUIRED NO_MODULE)

# ##
set(CMAKE_POSITION_INDEPENDENT_CODE ON)  # We need to add this !
# ##

# the code
add_subdirectory(src)

# header files, note the "/" after include
install(DIRECTORY include/
  DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant