Add a feature flag that controls PIN caching. #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While SecretVec prevents accidentally logging or printing the PIN, caching the PIN in RAM in a long-running application would presumably allow it to be read from memory, or even from disk if the program gets swapped out. This commit adds a feature (enabled by default) that controls PIN caching. If the `cache-pin` feature is disabled, the PIN is not cached in memory and some YubiKey methods become unavailable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While SecretVec prevents accidentally logging or printing the PIN, caching the PIN in RAM in a long-running application would presumably allow it to be read from memory, or even from disk if the program gets swapped out.
This commit adds a feature (enabled by default) that controls PIN caching. If the
cache-pinfeature is disabled, the PIN is not cached in memory and some YubiKey methods become unavailable.