-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make connectable and connection public #481
base: main
Are you sure you want to change the base?
Make connectable and connection public #481
Conversation
For reference, reqwest based connector implementation |
I'm not familiar with UDS... it it something you actually intend to use? |
While implementing https connector in the library would cover one of the use-cases that yubihsm-connector supports, I would still love to proceed with this approach as well. Now if I bring UDS as an example, it's not something what yubihsm-connector officially supports at first place, and is rather specific to my organization - therefore it's not worth upstreaming & maintaining here. I believe this change could be useful for others who want to do non-standard communication and don't want to maintain a fork of this library. |
Bump, is this PR still acceptable? |
It's out-of-date with the base branch. And... I guess, I don't understand your use case and it's more API surface to keep stable instead of being able to refactor, but I guess the counterpoint is we haven't touched it in awhile so it is defacto stable. |
I don't know how I can explain the use-case simpler than I did in PR description... perhaps that to keep this library small and not pull in heavy dependencies like Reason why I asked if this PR is acceptable, is to decide if I'll bother with rebasing it, or just close it. |
I guess I can merge it if you update it |
af09b85
to
840a43e
Compare
Rebase done |
This allows to implement new connector backends externally (e.g. HTTPS or UDS) by implementing Connectable and Connection traits.