Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metrics #692

Open
freak12techno opened this issue Jan 8, 2023 · 6 comments
Open

Prometheus metrics #692

freak12techno opened this issue Jan 8, 2023 · 6 comments

Comments

@freak12techno
Copy link
Contributor

I'm using Prometheus a lot of metrics and alerting and it'd be nice if tmkms would expose some of its own metrics in a Prometheus compatible format so I'd have an overview on how good tmkms is performing and can add another alerts set for it. At least the following would be nice to have:

  • last signed h/r/s
  • whether tmkms was able to connect successfully to a fullnode or not, or errors count
  • doublesign attempts

Do you think it's possible or desireable?

@tony-iqlusion
Copy link
Member

See #667

@freak12techno
Copy link
Contributor Author

That would solve it for me. Any estimation on when this can be merged?

@tony-iqlusion
Copy link
Member

tony-iqlusion commented Jan 8, 2023

Whenever I have time to review it.

In the meantime you can run that branch and report back on how well it's working, which would be helpful with the review process.

@zheli
Copy link

zheli commented Jul 28, 2023

+1

@tony-iqlusion
Copy link
Member

My feedback on #667 (which is now stale) was that I would prefer to use https://autometrics.dev/ instead

@tony-iqlusion tony-iqlusion changed the title Tmkms metrics Prometheus metrics Oct 25, 2023
@freak12techno
Copy link
Contributor Author

@tony-iqlusion any news on that? I'd say having metrics for the app that's responsible for signing blocks and that's potentially securing millions of dollars (and may cause huge losses if something is not right), this seems like a must.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants