Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmkms prometheus endpoint #129

Closed
franono opened this issue Sep 2, 2020 · 4 comments
Closed

tmkms prometheus endpoint #129

franono opened this issue Sep 2, 2020 · 4 comments

Comments

@franono
Copy link

franono commented Sep 2, 2020

Would it be possible to have a prometheus endpoint built into tmkms for monitoring. This would allow us to better monitor the KMS module, as at the moment we're monitoring it through its logs.

Some ideas that could be useful:

Counters for:
signed_prevotes
signed_precommits
signed_proposals
timeouts/errors

Other:
Number of validator_connections
hsm_delay time/histogram
chain block heights

Would appreciate your thoughts and possibility of this, thank you!

@tony-iqlusion
Copy link
Member

Sure, it's a good idea

@franono
Copy link
Author

franono commented Oct 5, 2020

Any update on the possibility on including this please? @tony-iqlusion

@tony-iqlusion
Copy link
Member

There are many other things we are prioritizing at the moment (e.g. Stargate upgrade).

The fastest way to see it added would be to open a PR.

@tony-iqlusion
Copy link
Member

Closing in favor of #692

@tony-iqlusion tony-iqlusion closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants