Performance issue caused by invoking 'rte_malloc' frequently. #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyinskyabc
commented
Jun 24, 2020
flyinskyabc
commented
- Deprecate 'rte_malloc', use 'rte_mempool_get' for inserting UOA instead.
- Remove unnecessary reference counting for 'struct inet_device'.
1. Deprecate 'rte_malloc', use 'rte_mempool_get' for inserting UOA instead. 2. Remove unnecessary reference counting for 'struct inet_device'.
ywc689
reviewed
Jul 20, 2020
| 0, NULL, NULL, NULL, NULL, i, 0); | ||
|
|
||
| if (unlikely(!g_uoa_cache[i])) { | ||
| return EDPVS_NOMEM; |
There was a problem hiding this comment.
free previous uoa_cache memory before return
ywc689
added
pr/needs-confirmed
ywc689
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Codes are OK now. But mempool of the same size with dp_vs_conn may not memory friendly enough.
Actually, we are planning to fix rte_malloc problem in all critical packet pathes using dpvs's mempool， which supports variable length mempool and provides a balance between rte_malloc and dpdk mempool.You could help us with the plan if you are interested with it.
ywc689
added
pr/codes-reviewed-ok
donghaobo
reviewed
Mar 8, 2021
| @@ -177,8 +181,8 @@ static int udp_conn_sched(struct dp_vs_proto *proto, | |||
| if ((*conn)->dest->fwdmode == DPVS_FWD_MODE_FNAT && g_uoa_max_trail > 0) { | |||
| struct conn_uoa *uoa; | |||
|
|
|||
| (*conn)->prot_data = rte_zmalloc(NULL, sizeof(struct conn_uoa), 0); | |||
| if (!(*conn)->prot_data) { | |||
| err = rte_mempool_get(this_uoa_cache, (void **)&((*conn)->prot_data)); | |||
There was a problem hiding this comment.
for now, struct conn_uoa has 6 bytes only, maybe use prot_data directly
uoa = (void*)&(*conn)->prot_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.