Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix refcount issue when adding/removing VIP group #594

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

fix refcount issue when adding/removing VIP group #594

wants to merge 2 commits into from

Conversation

royhunter
Copy link
Contributor

  1. Increase VS's refcount when adding one RS
  2. Decrease VS's refcount when deleteing one RS
  3. Remove VS when its refcount is zero(No RS associated)

@royhunter
fix refcount issue when adding/removing VIP group
7dc4dd0 
1. Increase VS's refcount when adding one RS
2. Decrease VS's refcount when deleteing one RS
3. Remove VS when its refcount is zero(No RS associated)
@ywc689 ywc689 requested a review from ytwang0320 July 16, 2020 01:20
@ywc689 ywc689 requested a review from azura27 September 9, 2020 01:04
@ywc689 ywc689 added pr/to-review-codes review codes line by line and check if problem exists. pr/bug-confirmed the bug in the bugfix pr actually exists, and list cases can verify the effectiveness of the bugfix labels Sep 9, 2020
@azura27
Copy link
Collaborator

azura27 commented Sep 14, 2020

@royhunter the commit "@royhunter
fix refcount issue when adding/removing VIP group" is test OK for the solution of #631, Thanks a lot
@ywc689

@azura27
Copy link
Collaborator

azura27 commented Sep 14, 2020 •
edited
Loading

@royhunter When you are free , please delete the commit of "enable coredump generation" on the PR, for the commit has been PR ed at #619

@azura27 azura27 added the pr/codes-tested-ok compile ok and specified tests passed label Sep 14, 2020
@liweitianux
Copy link
Contributor

Yes. I've tested that this PR (the refcount commit within it) fixes the keepalived issue #631

@ywc689 ywc689 added pr/codes-need-change problems found in the line-by-line code review and need to be fixed and removed pr/to-review-codes review codes line by line and check if problem exists. pr/bug-confirmed the bug in the bugfix pr actually exists, and list cases can verify the effectiveness of the bugfix labels Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytwang0320 ytwang0320 Awaiting requested review from ytwang0320

@azura27 azura27 Awaiting requested review from azura27

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pr/codes-need-change problems found in the line-by-line code review and need to be fixed pr/codes-tested-ok compile ok and specified tests passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@royhunter @azura27 @liweitianux @ywc689