ipvs: fix issue #947, a compiling error caused by string overflow war…

…ning with gcc version 8.0+ Signed-off-by: ywc689 <[email protected]>
iqiyi · Apr 19, 2024 · efc101b · efc101b
1 parent f7b0b50
commit efc101b
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/ipvs/ip_vs_proxy_proto.c b/src/ipvs/ip_vs_proxy_proto.c
@@ -484,8 +484,10 @@ int proxy_proto_insert(struct proxy_info *ppinfo, struct dp_vs_conn *conn,
                 if (unlikely(NULL == inet_ntop(AF_INET, &ppinfo->addr.ip4.dst_addr,
                                 tbuf2, sizeof(tbuf2))))
                     return EDPVS_INVAL;
-                sprintf(ppv1buf, "PROXY TCP4 %s %s %d %d\r\n", tbuf1, tbuf2,
-                        ntohs(ppinfo->addr.ip4.src_port), ntohs(ppinfo->addr.ip4.dst_port));
+                if (unlikely(snprintf(ppv1buf, sizeof(ppv1buf), "PROXY TCP4 %s %s %d %d\r\n",
+                            tbuf1, tbuf2, ntohs(ppinfo->addr.ip4.src_port),
+                            ntohs(ppinfo->addr.ip4.dst_port)) > sizeof(ppv1buf)))
+                    return EDPVS_INVAL;
                 break;
             case AF_INET6:
                 if (unlikely(NULL == inet_ntop(AF_INET6, ppinfo->addr.ip6.src_addr,
@@ -494,8 +496,10 @@ int proxy_proto_insert(struct proxy_info *ppinfo, struct dp_vs_conn *conn,
                 if (unlikely(NULL == inet_ntop(AF_INET6, ppinfo->addr.ip6.dst_addr,
                                 tbuf2, sizeof(tbuf2))))
                     return EDPVS_INVAL;
-                sprintf(ppv1buf, "PROXY TCP6 %s %s %d %d\r\n", tbuf1, tbuf2,
-                        ntohs(ppinfo->addr.ip6.src_port), ntohs(ppinfo->addr.ip6.dst_port));
+                if (unlikely(snprintf(ppv1buf, sizeof(ppv1buf), "PROXY TCP6 %s %s %d %d\r\n",
+                                tbuf1, tbuf2, ntohs(ppinfo->addr.ip6.src_port),
+                                ntohs(ppinfo->addr.ip6.dst_port)) > sizeof(ppv1buf)))
+                    return EDPVS_INVAL;
                 break;
             default:
                 return EDPVS_NOTSUPP;