Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise get_node function #59

Closed
mbhall88 opened this issue Oct 15, 2018 · 2 comments
Closed

Optimise get_node function #59

mbhall88 opened this issue Oct 15, 2018 · 2 comments
Assignees
@mbhall88
Labels
enhancement Performance

Comments

@mbhall88
Copy link
Member

get_node is currently causing up to 6 iterations through the graph per start/end kmer combination.
@mbhall88
Copy link
Member Author

Create a hash of all the kmers in the graph and use this to test for existence.

This was referenced Oct 15, 2018
Closed
Merged
@mbhall88
Copy link
Member Author

Based on some of the results in #74 I don't think these iterations through the graph are creating any tangible performance impact, therefore this issue can be parked for now.

@rmcolq rmcolq closed this as completed Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbhall88 mbhall88

Labels
enhancement Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ffranr @rmcolq @mbhall88